Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] bump(k8s): update k8s.io/* dependencies #1982

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[WIP] bump(k8s): update k8s.io/* dependencies #1982

wants to merge 15 commits into from

Conversation

bertinatto
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 31, 2024

Hello @bertinatto! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 31, 2024
@openshift-ci openshift-ci bot requested review from knobunc and soltysh July 31, 2024 20:07
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bertinatto
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2024
@bertinatto bertinatto force-pushed the bump-1.31 branch 3 times, most recently from 80b7536 to a708e0d Compare August 22, 2024 20:00
atiratree and others added 15 commits August 23, 2024 10:32
@atiratree @bertinatto
bump(k8s): update k8s.io/* dependencies to v1.31.0
d8e081f
@atiratree @bertinatto
bump(k8s): go mod vendor
d541dbc
@atiratree @bertinatto
bump(k8s): tools: update k8s.io/* dependencies to v1.31.0
f7c58ca 
- removed exclude for github.com/sergi/go-diff as it should have been
  fixed by sergi/go-diff#136
@atiratree @bertinatto
bump(k8s): go mod vendor and tools: go mod vendor
39eb968
@atiratree @bertinatto
update openapi generator to use k8s.io/gengo/v2
5b3b80c
@atiratree @bertinatto
make apimachinery/pkg/version/ optional dependency for openapi genera…
8294eb8 
…tion
@atiratree @bertinatto
bump(k8s): tools: make k8s.io/gengo/v2 explicit in go.mod
0f26f18
@atiratree @bertinatto
fix update-protobuf.sh script
2996513
@JoelSpeed @bertinatto
Update pre-release lifecycle gen script
9dec6e1
@atiratree @bertinatto
fix machine types for update-codegen-crds.sh
2416088
@atiratree @bertinatto
fix verify-prerelease-lifecycle-gen.sh
30ea6a8 
--verify-only option has been removed, so use git diff instead
@atiratree @bertinatto
add new image fs type
841d5ef
@bertinatto
bump(k8s): make update
0af3230
@bertinatto
Add missing ObjectMeta to authorization types
ee6a14d 
The changes introduced in kubernetes/kubernetes#121439,
require that all types used with the generated clients implement both runtime.Object
and meta.ObjectMeta. This might be considered a regression, but we
decided that adjusting our code is a better approach.
@bertinatto
bump(k8s): update all
2f415fb
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 23, 2024

@bertinatto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview 2f415fb link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-hypershift 2f415fb link true /test e2e-aws-ovn-hypershift
ci/prow/integration 2f415fb link true /test integration
ci/prow/verify-crd-schema 2f415fb link true /test verify-crd-schema
ci/prow/e2e-aws-serial-techpreview 2f415fb link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn 2f415fb link true /test e2e-aws-ovn
ci/prow/verify-client-go 2f415fb link true /test verify-client-go

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc Awaiting requested review from knobunc

@soltysh soltysh Awaiting requested review from soltysh

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bertinatto @openshift-merge-robot @atiratree @JoelSpeed