Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image in CatalogSource #31

Merged

Conversation

divyansh42
Copy link
Contributor

Noticed at other places in task repos we are using a different image.
So updating the image in CatalogSource to be consistent with other task repositories

@@ -51,7 +51,7 @@ metadata:
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/openshift-pipeline/openshift-pipelines-operator-index:1.10
image: quay.io/openshift-pipeline/openshift-pipelines-pipelines-operator-bundle-container-index:v4.14-candidate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this should be 4.15 or 4.16

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am doing 4.15 for now.

@divyansh42 divyansh42 force-pushed the update-image branch 2 times, most recently from b9b6fbd to 9d2209c Compare August 2, 2024 05:28
Signed-off-by: divyansh42 <diagrawa@redhat.com>
@savitaashture
Copy link
Member

@vdemeester
@divyansh42 mentioned that he will use 4.15 now because if he change to 4.16 he has to change task config and ci config
so when he add changes to multiple OCP version support he will make 4.15 as optional and 4.16 as default

Copy link

openshift-ci bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyansh42, savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d539f43 into openshift-pipelines:main Aug 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants