-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GitOps comments on Push commits #1638
base: main
Are you sure you want to change the base?
Add support for GitOps comments on Push commits #1638
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1638 +/- ##
==========================================
- Coverage 65.74% 65.74% -0.01%
==========================================
Files 178 178
Lines 13836 13835 -1
==========================================
- Hits 9097 9096 -1
Misses 4124 4124
Partials 615 615 ☔ View full report in Codecov by Sentry. |
db66b1c
to
6c8e044
Compare
b760cb0
to
b44b6d3
Compare
266c125
to
62df1d1
Compare
62df1d1
to
91263d9
Compare
91263d9
to
1d58c04
Compare
Add supports for GitOps comments on Push commits when using the Git Provider. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
1d58c04
to
e7b0f7f
Compare
@chmouel when I was running it manually it was working as expected but in E2E test I am getting below warning and PipelineRun wasn't being triggered.
|
while I am seeing that in E2E tests of this PR |
apart from this issue, rest is /LGTM |
Add supports for GitOps comments on Push commits when using the Git Provider.
Moved the RunPush function to use scm.PushFiles (which use the git binary instead of api) to push files like we do on gitea, since pushing to main via go-github was too painful..
Jira: https://issues.redhat.com/browse/SRVKP-4179
Changes
Submitter Checklist
📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).