-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tekton-chains #126
Implement tekton-chains #126
Conversation
@Roming22 Before going into the PR review, I would like to understand the use case for Tekton Chains installation in the workload clusters? Why do we need it? |
In our Phase 1 architecture, Tekton Chains needs to run on the workload cluster so that it can do the provenance attestation and image signing for TaskRuns (which only exist on workload clusters). @Roming22 - is there any reason why we are manually deploying Chains instead of using the Pipelines operator? There is a CR we can use to configure Chains via the Pipelines Operator: https://docs.openshift.com/container-platform/4.10/cicd/pipelines/using-tekton-chains-for-openshift-pipelines-supply-chain-security.html |
My understanding is that I cannot configure Chains using gitops if I install it using the CR. ArgoCD cannot control/patch a resource (in this case the Not that I know of at least 3 resources that we need to patch:
Let me know if I misunderstood something. |
/test all |
/retest |
/retest |
2 similar comments
/retest |
/retest |
@bnallapeta If you want to test, please use this branch. |
gitops/argocd/tekton-chains/overlays/openshift/security-context-fix.yaml
Show resolved
Hide resolved
@Roming22 Looks good apart from that one comment. But I see that the plnsvc-ckcp-test has failed. Please look into that. |
@bnallapeta The |
Configuration is taken verbatim from https://github.com/redhat-appstudio/infra-deployments/tree/ef1f8459a0ab86964c1421f7475fb41626cec905/components/build/tekton-chains Signed-off-by: Romain Arnaud <rarnaud@redhat.com>
@Roming22: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No worries. I've tested it locally using your branch. Looks good. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bnallapeta, Roming22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Configuration is taken verbatim from https://github.com/redhat-appstudio/infra-deployments/tree/ef1f8459a0ab86964c1421f7475fb41626cec905/components/build/tekton-chains
Signed-off-by: Romain Arnaud rarnaud@redhat.com
PR can be tested by running
./ckcp/openshift_dev_setup.sh
followed by./ckcp/test.sh chains
.