Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tekton-chains #126

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Implement tekton-chains #126

merged 1 commit into from
Sep 21, 2022

Conversation

Roming22
Copy link
Contributor

@Roming22 Roming22 commented Jun 28, 2022

Configuration is taken verbatim from https://github.com/redhat-appstudio/infra-deployments/tree/ef1f8459a0ab86964c1421f7475fb41626cec905/components/build/tekton-chains

Signed-off-by: Romain Arnaud rarnaud@redhat.com

PR can be tested by running ./ckcp/openshift_dev_setup.sh followed by ./ckcp/test.sh chains.

@Roming22 Roming22 requested review from bnallapeta and fgiloux June 28, 2022 21:05
@bnallapeta
Copy link
Contributor

@Roming22 Before going into the PR review, I would like to understand the use case for Tekton Chains installation in the workload clusters? Why do we need it?

@Roming22 Roming22 marked this pull request as draft June 29, 2022 12:43
@adambkaplan
Copy link
Contributor

In our Phase 1 architecture, Tekton Chains needs to run on the workload cluster so that it can do the provenance attestation and image signing for TaskRuns (which only exist on workload clusters).

@Roming22 - is there any reason why we are manually deploying Chains instead of using the Pipelines operator? There is a CR we can use to configure Chains via the Pipelines Operator: https://docs.openshift.com/container-platform/4.10/cicd/pipelines/using-tekton-chains-for-openshift-pipelines-supply-chain-security.html

@Roming22
Copy link
Contributor Author

Is there any reason why we are manually deploying Chains instead of using the Pipelines operator? There is a CR we can use to configure Chains via the Pipelines Operator: https://docs.openshift.com/container-platform/4.10/cicd/pipelines/using-tekton-chains-for-openshift-pipelines-supply-chain-security.html

My understanding is that I cannot configure Chains using gitops if I install it using the CR. ArgoCD cannot control/patch a resource (in this case the chains-config configmap) that is not declared in the application (source). This means we would have to run an oc patch command, which would go against the gitops model of declaring the state you want and letting the controller deal how to get to that state.

Not that I know of at least 3 resources that we need to patch:

  1. chains-config: to configure the format, storage, and transparency;
  2. tekton-chains-controller: to override the default image with the development image that supports pipelineruns, and override the runAs* ids;
  3. chains-certs-configuration: to setup the certificates differently on k8s and openshift.

Let me know if I misunderstood something.

@xinredhat
Copy link
Contributor

/test all

@Roming22 Roming22 removed the approved label Sep 7, 2022
@Roming22 Roming22 marked this pull request as ready for review September 7, 2022 20:48
@openshift-ci openshift-ci bot requested review from Mo3m3n and ramessesii2 September 7, 2022 20:48
@openshift-ci openshift-ci bot added the approved label Sep 8, 2022
@Roming22
Copy link
Contributor Author

Roming22 commented Sep 9, 2022

/retest

@Roming22
Copy link
Contributor Author

Roming22 commented Sep 9, 2022

/retest

2 similar comments
@Roming22
Copy link
Contributor Author

/retest

@xinredhat
Copy link
Contributor

/retest

@Roming22
Copy link
Contributor Author

@bnallapeta If you want to test, please use this branch.

ckcp/test.sh Outdated Show resolved Hide resolved
ckcp/test.sh Outdated Show resolved Hide resolved
ckcp/test.sh Outdated Show resolved Hide resolved
gitops/argocd/tektoncd/tekton-chains.yaml Outdated Show resolved Hide resolved
gitops/sre/credentials/manifests/README.md Outdated Show resolved Hide resolved
ckcp/test.sh Outdated Show resolved Hide resolved
@bnallapeta
Copy link
Contributor

@Roming22 Looks good apart from that one comment. But I see that the plnsvc-ckcp-test has failed. Please look into that.

ckcp/test.sh Outdated Show resolved Hide resolved
ckcp/test.sh Outdated Show resolved Hide resolved
@Roming22
Copy link
Contributor Author

@bnallapeta The plnsvc-ckcp-test cannot succeed until the PR has been merged since it relies on having the manifests committed to main.

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2022

@Roming22: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/plnsvc-ckcp-test 4b3d626 link true /test plnsvc-ckcp-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bnallapeta
Copy link
Contributor

@bnallapeta The plnsvc-ckcp-test cannot succeed until the PR has been merged since it relies on having the manifests committed to main.

No worries. I've tested it locally using your branch. Looks good.

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bnallapeta, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Roming22,bnallapeta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bnallapeta bnallapeta merged commit 1ecd8c8 into openshift-pipelines:main Sep 21, 2022
@Roming22 Roming22 deleted the feat/tekton-chains branch October 6, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants