add multiarch support to manual approval gate feature #171
Conversation
|
Hi @Basavaraju-G. Thanks for your PR. I'm waiting for a openshift-pipelines member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -88,4 +88,4 @@ jobs: | |||
| password: ${{ secrets.GITHUB_TOKEN }} | |||
| - uses: imjasonh/setup-ko@v0.7 | |||
| - run: | | |||
| ko publish --push=${{ github.event_name != 'pull_request' }} --base-import-paths ./cmd/controller | |||
There was a problem hiding this comment.
okay @piyush-garg i will add it.
There was a problem hiding this comment.
should we add arm also?
Added.
Basavaraju-G
force-pushed
the
add-multiarch-support
branch
from
fa93b47 to
6d7ce5b
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Basavaraju-G, PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ff223db
into
openshift-pipelines:main
This PR will add support for s390x,ppc64le multi architecture support.
#168