Adds timeout support for approval task #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PuneetPunamiya
force-pushed
the
add-support-for-timeout
branch
from
358afca to
c3d96bd
Compare
PuneetPunamiya
force-pushed
the
add-support-for-timeout
branch
from
c3d96bd to
3a49d6e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
PuneetPunamiya
force-pushed
the
add-support-for-timeout
branch
from
3a49d6e to
9913254
Compare
piyush-garg
reviewed
Apr 25, 2024
|
|
||
| timeout := run.Spec.Timeout | ||
| if timeout == nil { | ||
| timeout = &metav1.Duration{Duration: time.Duration(60) * time.Minute} |
There was a problem hiding this comment.
should we make the default value configurable ?
There was a problem hiding this comment.
Yeah, is it fine if I address this in a follow up pr and may be we can get this pr in?
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.