Add auth using webhook #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PuneetPunamiya
force-pushed
the
add-auth-using-webhook
branch
from
520f6ff to
8a8d1ef
Compare
16 tasks
|
/test unit |
|
/retest |
PuneetPunamiya
force-pushed
the
add-auth-using-webhook
branch
from
8a8d1ef to
ce4e5ac
Compare
|
/retest |
PuneetPunamiya
force-pushed
the
add-auth-using-webhook
branch
from
ce4e5ac to
ff0c52a
Compare
piyush-garg
reviewed
Apr 17, 2024
piyush-garg
reviewed
Apr 17, 2024
PuneetPunamiya
force-pushed
the
add-auth-using-webhook
branch
from
ff0c52a to
4bd2c19
Compare
PuneetPunamiya
force-pushed
the
add-auth-using-webhook
branch
from
4bd2c19 to
818f07a
Compare
jkandasa
reviewed
Apr 23, 2024
PuneetPunamiya
force-pushed
the
add-auth-using-webhook
branch
from
818f07a to
29ce138
Compare
This patch adds a webhook controller which handles following validations - Checks if approval is required by the approver - Checks if username is mentioned in the approval task - Checks if user is updating the input for his name only Signed-off-by: PuneetPunamiya <ppunamiy@redhat.com>
PuneetPunamiya
force-pushed
the
add-auth-using-webhook
branch
from
29ce138 to
5f9bfae
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkandasa, PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 405fcbc
into
openshift-pipelines:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds auth using webhook :)
This patch adds a webhook controller which handles following validations
Signed-off-by: PuneetPunamiya ppunamiy@redhat.com