Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: New Kind generation #25

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tirthct
Copy link
Contributor

@tirthct tirthct commented Nov 21, 2023

This PR contains the output of the TRex code generator (see #27). In this example, a new Kind called "Subscription" is generated.

This PR will remain online as an example of a new Kind. It shows where various pieces need to be wired together, all of which are described in this project's README.

@tirthct tirthct marked this pull request as draft November 21, 2023 21:06
@tirthct tirthct marked this pull request as ready for review November 27, 2023 18:30
@tirthct tirthct changed the title Adding template code to generate openapi for kinds Add template to generate openapi for kinds Nov 27, 2023
@markturansky
Copy link
Contributor

markturansky commented Nov 27, 2023

This looks very good. Some suggestions:

  1. extract the generator stuff and README to a separate PR (or extract the generated Subscription stuff from this one)
  2. put generated "Subscription" stuff in another PR.
  3. provide link in README where you explain usage of the generator to the sample PR with everything generated.

we merge the generator parts, but leave open the example PR with notes that explain what/why. Future improvements to the generator (to remove those remaining manual bits) can be generated anew for the open example PR.

@tirthct
Copy link
Contributor Author

tirthct commented Nov 28, 2023

This looks very good. Some suggestions:

1. extract the generator stuff and README to a separate PR (or extract the generated Subscription stuff from this one)

2. put generated "Subscription" stuff in another PR.

3. provide link in README where you explain usage of the generator to the sample PR with everything generated.

we merge the generator parts, but leave open the example PR with notes that explain what/why. Future improvements to the generator (to remove those remaining manual bits) can be generated anew for the open example PR.

Separated out generator stuff in MR #27

@markturansky markturansky changed the title Add template to generate openapi for kinds Example: New Kind generation Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants