Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add role prefix flag on create wif-config #662

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Add role prefix flag on create wif-config #662

merged 1 commit into from
Aug 28, 2024

Conversation

JakobGray
Copy link
Contributor

renan-campos
renan-campos requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@renan-campos renan-campos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question on the alias, otherwise lgtm

cmd/ocm/gcp/create-wif-config.go Outdated Show resolved Hide resolved
renan-campos
renan-campos approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@renan-campos renan-campos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@renan-campos renan-campos merged commit 65bf8cf into openshift-online:main Aug 28, 2024
4 of 5 checks passed
@JakobGray JakobGray deleted the wif_role_prefix branch August 28, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renan-campos renan-campos renan-campos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakobGray @renan-campos