OCM-4183 | feat: suggest pop out an error message instead of stop the progress if user do not input the service account file #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoveiga
changed the title
tirthct
approved these changes
Oct 10, 2023
|
LGTM |
tirthct
added a commit
to tirthct/ocm-cli
that referenced
this pull request
Oct 13, 2023
-4dad47f OCM-3510 | fix: allow clusters to edit ingresses -57855bf fixed setting isGcpMarketplaceSubscriptionType for non interactive mode -557a66b making GCP service account file mandatory for CCS clusters (openshift-online#565) -1f5481b Add GCP marketplace terms and conditions for marketplace GCP clusters -47cd35c showing error and re-prompting service-account-file question if one is not provided (openshift-online#567) -0d3f4c3 OCM-4186 | Feat | Changed marketplace-gcp-terms error message for non-interactive mode (openshift-online#569) -455f27e OCM-4184 | Feat | Convert relative path containing tilde for service account file (openshift-online#568)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s not provided