support to run upgrade with e2e #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
/cc @morvencao @qiujian16 |
morvencao
reviewed
Jan 21, 2025
templates/service-tls-template.yml
Outdated
Comment on lines
403
to
404
| - --grpc-tls-cert-file=/secrets/grpc-server-tls/tls.crt | ||
| - --grpc-tls-key-file=/secrets/grpc-server-tls/tls.key |
There was a problem hiding this comment.
nit: this certificate pair is generated by openshift serving certificate, we don't use this. we use self signed certificate for auth.
There was a problem hiding this comment.
we create a secret with the self signed certs in the e2e-setup.sh (kubectl create secret generic maestro-grpc-cert), do you mean in the e2e we don't use it?
There was a problem hiding this comment.
remove the ocp serving certificatesgrpc-server-tls and only use our self signed certificates
Comment on lines
+411
to
+405
| - --grpc-tls-cert-file=/secrets/maestro-grpc-cert/server.crt | ||
| - --grpc-tls-key-file=/secrets/maestro-grpc-cert/server.key |
There was a problem hiding this comment.
we use this self signed certificate for auth in e2e testing.
There was a problem hiding this comment.
remove the grpc-server-tls and only use our self signed certificates
Signed-off-by: Wei Liu <liuweixa@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.