enable grpc broker work with openshift route and customize certificate. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @clyang82 |
clyang82
reviewed
Jan 13, 2025
| check(fmt.Errorf("failed to append broker client CA to cert pool"), "Can't start gRPC broker") | ||
| } | ||
| tlsConfig.ClientCAs = certPool | ||
| tlsConfig.ClientAuth = tls.RequireAndVerifyClientCert |
There was a problem hiding this comment.
look like no verify-full, I get this from https://github.com/grpc/grpc-go/blob/master/examples/features/encryption/mTLS/server/main.go#L67C1-L71C3
|
/ok-to-test |
Signed-off-by: morvencao <lcao@redhat.com>
morvencao
force-pushed
the
br_grpc_enhancement
branch
from
c58762f to
9464d47
Compare
|
rebased the code. |
clyang82
reviewed
Jan 14, 2025
| @@ -139,6 +139,8 @@ func NewHelper(t *testing.T) *Helper { | |||
| // Set the healthcheck interval to 1 second for testing | |||
| helper.Env().Config.HealthCheck.HeartbeartInterval = 1 | |||
| helper.HealthCheckServer = server.NewHealthCheckServer() | |||
| // Disable TLS for testing | |||
| helper.Env().Config.GRPCServer.DisableTLS = true | |||
There was a problem hiding this comment.
why do you disable TLS here? I saw you are using OCP serving certs to generate certs.
There was a problem hiding this comment.
tls is disabled for integration testing, this is how helper.Env().Config.GRPCServer.DisableTLS = true works.
but for e2e testing, it is enabled, we generate the openshift serving certificate for grpc broker TLS.
|
/ok-to-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://issues.redhat.com/browse/ACM-16839