Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Tests for multitenancy with Service Mesh #2126

Closed
wants to merge 32 commits into from
Closed

[WIP] Tests for multitenancy with Service Mesh #2126

wants to merge 32 commits into from

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Jun 19, 2023 •
edited
Loading

Fixes https://issues.redhat.com/browse/SRVCOM-2522

Proposed Changes

  • Rewrite tests from https://github.com/ReToCode/knative-multitenancy in Golang. They're under test/servinge2e/servicemesh/
  • Remove TestKnativeVersusKubeServicesInOneNamespace as it's redundant. Having Knative and k8s service in one namespace is tested with all Eventing tests which now include KSVC in the test scenarios.
  • Add authorization policies so that Eventing and Eventing Kafka Broker tests pass. But this PR doesn't include any tests for verifying cross-tenant traffic for Eventing. They depend on Send namespace header in MT components knative/eventing#7048 to be merged and backported.
  • Split the test webhook under serving/metadata-webhook into cluster-resources and namespaced-resources. The second one needs to be applied with -n <namespace>. This is to reduce duplication of code because the webhook is now used in two namespaces: serving-tests, serverless-tests.

@openshift-ci openshift-ci bot requested review from pierDipi and ReToCode June 19, 2023 14:02
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link
Contributor Author

mgencur commented Jun 19, 2023

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

@mgencur: The following commands are available to trigger required jobs:

  • /test 4.10-images
  • /test 4.10-operator-e2e-aws-ocp-410
  • /test 4.10-ui-tests
  • /test 4.12-aws-ovn-images
  • /test 4.12-azure-images
  • /test 4.12-gcp-images
  • /test 4.12-hypershift-images
  • /test 4.12-images
  • /test 4.12-operator-e2e-aws-ocp-412
  • /test 4.12-osd-images
  • /test 4.12-ui-tests
  • /test 4.12-vsphere-images
  • /test ocp4.14-lp-interop-images
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test 4.10-e2e-kitchensink-ocp-410
  • /test 4.10-upgrade-kitchensink-ocp-410
  • /test 4.10-upgrade-tests-aws-ocp-410
  • /test 4.10-upstream-e2e-aws-ocp-410
  • /test 4.10-upstream-e2e-kafka-aws-ocp-410
  • /test 4.10-upstream-e2e-mesh-aws-ocp-410
  • /test 4.12-e2e-kitchensink-ocp-412
  • /test 4.12-upgrade-kitchensink-ocp-412
  • /test 4.12-upgrade-tests-aws-ocp-412
  • /test 4.12-upstream-e2e-aws-ocp-412
  • /test 4.12-upstream-e2e-kafka-aws-ocp-412
  • /test 4.12-upstream-e2e-mesh-aws-ocp-412

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-knative-serverless-operator-main-4.10-images
  • pull-ci-openshift-knative-serverless-operator-main-4.12-aws-ovn-images
  • pull-ci-openshift-knative-serverless-operator-main-4.12-azure-images
  • pull-ci-openshift-knative-serverless-operator-main-4.12-gcp-images
  • pull-ci-openshift-knative-serverless-operator-main-4.12-hypershift-images
  • pull-ci-openshift-knative-serverless-operator-main-4.12-images
  • pull-ci-openshift-knative-serverless-operator-main-4.12-operator-e2e-aws-ocp-412
  • pull-ci-openshift-knative-serverless-operator-main-4.12-osd-images
  • pull-ci-openshift-knative-serverless-operator-main-4.12-upgrade-tests-aws-ocp-412
  • pull-ci-openshift-knative-serverless-operator-main-4.12-upstream-e2e-aws-ocp-412
  • pull-ci-openshift-knative-serverless-operator-main-4.12-upstream-e2e-kafka-aws-ocp-412
  • pull-ci-openshift-knative-serverless-operator-main-4.12-vsphere-images
  • pull-ci-openshift-knative-serverless-operator-main-ocp4.14-lp-interop-images
  • pull-ci-openshift-knative-serverless-operator-main-unit-test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgencur
Copy link
Contributor Author

mgencur commented Jun 19, 2023

/test 4.12-upstream-e2e-mesh-aws-ocp-412

4 similar comments
@mgencur
Copy link
Contributor Author

mgencur commented Jun 20, 2023

/test 4.12-upstream-e2e-mesh-aws-ocp-412

@mgencur
Copy link
Contributor Author

mgencur commented Jun 20, 2023

/test 4.12-upstream-e2e-mesh-aws-ocp-412

@mgencur
Copy link
Contributor Author

mgencur commented Jun 20, 2023

/test 4.12-upstream-e2e-mesh-aws-ocp-412

@mgencur
Copy link
Contributor Author

mgencur commented Jun 27, 2023

/test 4.12-upstream-e2e-mesh-aws-ocp-412

@mgencur mgencur changed the title [WIP] Tests for multitenancy with Service Mesh Tests for multitenancy with Service Mesh Jun 28, 2023
@mgencur
Copy link
Contributor Author

mgencur commented Jun 28, 2023

/test 4.12-upstream-e2e-mesh-aws-ocp-412
/test 4.10-upstream-e2e-mesh-aws-ocp-410

@mgencur
Copy link
Contributor Author

mgencur commented Jun 30, 2023

/test 4.12-upstream-e2e-mesh-aws-ocp-412

@mgencur
Copy link
Contributor Author

mgencur commented Jun 30, 2023

/test 4.12-upstream-e2e-mesh-aws-ocp-412

@mgencur mgencur changed the title Tests for multitenancy with Service Mesh [WIP] Tests for multitenancy with Service Mesh Jun 30, 2023
@mgencur
Copy link
Contributor Author

mgencur commented Jun 30, 2023

/test 4.12-upstream-e2e-mesh-aws-ocp-412

@mgencur
Copy link
Contributor Author

mgencur commented Jun 30, 2023

/test 4.12-upstream-e2e-mesh-aws-ocp-412

1 similar comment
@mgencur
Copy link
Contributor Author

mgencur commented Jul 3, 2023

/test 4.12-upstream-e2e-mesh-aws-ocp-412

@mgencur
Copy link
Contributor Author

mgencur commented Jul 3, 2023

/test 4.12-upstream-e2e-mesh-aws-ocp-412

@mgencur
Copy link
Contributor Author

mgencur commented Jul 4, 2023

/test 4.12-upstream-e2e-mesh-aws-ocp-412

@nak3
Copy link
Contributor

nak3 commented Jul 6, 2023

/retest

@ReToCode
Copy link
Member

ReToCode commented Jul 6, 2023

/hold

I have some idea on how to fix this. I'm going to update this PR with some changes to see if this helps for all the test cases or not.

@ReToCode ReToCode mentioned this pull request Jul 6, 2023
Closed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

@mgencur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.10-upstream-e2e-mesh-aws-ocp-410 31164b2 link false /test 4.10-upstream-e2e-mesh-aws-ocp-410
ci/prow/4.12-upstream-e2e-mesh-aws-ocp-412 f7d4a8e link false /test 4.12-upstream-e2e-mesh-aws-ocp-412
ci/prow/4.13-vsphere-images f7d4a8e link true /test 4.13-vsphere-images
ci/prow/4.13-osd-images f7d4a8e link true /test 4.13-osd-images
ci/prow/4.13-azure-images f7d4a8e link true /test 4.13-azure-images
ci/prow/4.13-hypershift-images f7d4a8e link true /test 4.13-hypershift-images
ci/prow/4.13-gcp-images f7d4a8e link true /test 4.13-gcp-images
ci/prow/4.13-aws-ovn-images f7d4a8e link true /test 4.13-aws-ovn-images
ci/prow/4.13-single-node-images f7d4a8e link true /test 4.13-single-node-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ReToCode ReToCode mentioned this pull request Jul 20, 2023
Closed
@mgencur
Copy link
Contributor Author

mgencur commented Jul 26, 2023

Changes from this PR will be integrated in separate PRs.

@mgencur mgencur closed this Jul 26, 2023
This was referenced Jul 27, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi Awaiting requested review from pierDipi

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees
No one assigned
Labels
approved do-not-merge/hold do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgencur @nak3 @ReToCode @openshift-merge-robot