Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding deprecated label to "legacy" sources #22

Merged

Conversation

matzew
Copy link
Member

@matzew matzew commented May 6, 2020

For SRVKE-420

Proposed Changes

  • adding deprecated labels to "legacy" source types

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@invincibleJai
Copy link

@matzew thanks for updating it, with this containerSource will get deprecated as we only have containersources.sources.eventing.knative.dev for containerSource and not containersources.sources.knative.dev

@matzew
Copy link
Member Author

matzew commented May 6, 2020

@invincibleJai on 0.13 there is ONLY the containersources.sources.eventing.knative.dev - that was marked as deprecated in fav. of the sinkbinding. (original idea around 0.13 release cut).

I wrote a migration guide:

However, there was lot's of noise, disagreement and bikeshed.

With the result that in 0.14 it got added back:

Note: It did "re-introduce" in containersources.sources.knative.dev API group

Copy link

@invincibleJai invincibleJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks , looks good :)

@aliok
Copy link

aliok commented May 7, 2020

/lgtm

@aliok
Copy link

aliok commented May 7, 2020

/approved

@aliok
Copy link

aliok commented May 7, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aliok, matzew
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok aliok merged commit cd58d39 into openshift-knative:release-0.13.2 May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants