Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.14] Report error for unsupported PKCS #1 format for the private key #1280

Conversation

pierDipi
Copy link
Member

Java Kafka clients don't support PKCS #1 format for private keys.

Java Kafka clients don't support PKCS #1 format for private keys.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d0f70a2 and 2 for PR HEAD 69cbcd4 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d0f70a2 and 2 for PR HEAD 69cbcd4 in total

@matzew
Copy link
Member

matzew commented Sep 25, 2024

/retest

Copy link

openshift-ci bot commented Sep 25, 2024

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/416-test-reconciler-keda-aws-416 69cbcd4 link true /test 416-test-reconciler-keda-aws-416
ci/prow/416-test-reconciler-aws-416 69cbcd4 link true /test 416-test-reconciler-aws-416
ci/prow/416-test-conformance-aws-416 69cbcd4 link true /test 416-test-conformance-aws-416
ci/prow/416-test-e2e-aws-416 69cbcd4 link true /test 416-test-e2e-aws-416
ci/prow/416-test-reconciler-encryption-auth-aws-416 69cbcd4 link true /test 416-test-reconciler-encryption-auth-aws-416

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pierDipi pierDipi merged commit 4cc583f into openshift-knative:release-v1.14 Sep 25, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants