[release-v1.14] Allow enabling sarama logging and disabling client pool and Upgrade knative.dev/eventing to latest 1.14 #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierDipi
changed the title
1 similar comment
|
/retest |
knative-extensions#4103) (knative-extensions#4107) * Allow enabling sarama logging and disabling client pool (knative-extensions#4103) Add 3 new environment variables: ``` ENABLE_SARAMA_LOGGER (default: false) ENABLE_SARAMA_DEBUG_LOGGER (default: false) ENABLE_SARAMA_CLIENT_POOL (default: true) ``` Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Set GetKafkaClient Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
…xtensions#4113) * Upgrade knative.dev/eventing to latest 1.14 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Pass PodLister as expected Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Migrate to library SchedulerFunc to use the new signature Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
cp-1754676fd439db2b8397eaed19701542072e583a-v1.14
branch
from
1a0b8ee
to
1721249
Compare
|
/retest-required |
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
cp-1754676fd439db2b8397eaed19701542072e583a-v1.14
branch
from
1721249
to
58f5ca2
Compare
Error: ``` 2024-09-25T10:41:51.023869929Z panic: Unable to fetch k8s.io/client-go/informers/core/v1.PodInformer with selector app.kubernetes.io/kind=kafka-dispatcher from context. ``` Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pierDipi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test 416-test-reconciler-encryption-auth-aws-416 |
pierDipi
merged commit d3f6b04
into
openshift-knative:release-v1.14
5 of 7 checks passed
pierDipi
deleted the
cp-1754676fd439db2b8397eaed19701542072e583a-v1.14
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of