Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of jackson-databind for sql-jdbc only #943

Merged

Conversation

GumpacG
Copy link
Collaborator

@GumpacG GumpacG commented Oct 20, 2022

Signed-off-by: Guian Gumpac guiang@bitquilltech.com

Description

Updated jackson-databind version for sql-jdbc to fix the CVE

Issues Resolved

#897

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Guian Gumpac added 2 commits October 20, 2022 09:34
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #943 (b3124b3) into 2.x (057fa44) will decrease coverage by 2.68%.
The diff coverage is 99.46%.

❗ Current head b3124b3 differs from pull request most recent head 94ff931. Consider uploading reports for the commit 94ff931 to get more accurate results

@@             Coverage Diff              @@
##                2.x     #943      +/-   ##
============================================
- Coverage     97.87%   95.18%   -2.69%     
- Complexity     3020     3126     +106     
============================================
  Files           284      309      +25     
  Lines          7425     8392     +967     
  Branches        475      618     +143     
============================================
+ Hits           7267     7988     +721     
- Misses          157      350     +193     
- Partials          1       54      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 97.94% <99.46%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <ø> (ø)
...h/sql/expression/function/OpenSearchFunctions.java 100.00% <ø> (ø)
...ensearch/sql/ppl/utils/PPLQueryDataAnonymizer.java 100.00% <ø> (ø)
...theus/data/constants/PrometheusFieldConstants.java 0.00% <0.00%> (ø)
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <100.00%> (ø)
...org/opensearch/sql/analysis/HighlightAnalyzer.java 100.00% <100.00%> (ø)
...org/opensearch/sql/analysis/model/CatalogName.java 100.00% <100.00%> (ø)
...ql/analysis/model/CatalogSchemaIdentifierName.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/analysis/model/SchemaName.java 100.00% <100.00%> (ø)
...opensearch/sql/expression/HighlightExpression.java 100.00% <100.00%> (ø)
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Guian Gumpac <guiang@bitquilltech.com>
@GumpacG GumpacG changed the title Testing updated version of jackson-databind Testing updated version of jackson-databind for only sql-jdbc Oct 20, 2022
Copy link
Collaborator

@MaxKsyunz MaxKsyunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @GumpacG !

@GumpacG GumpacG marked this pull request as ready for review October 20, 2022 18:05
@GumpacG GumpacG requested a review from a team as a code owner October 20, 2022 18:05
@Yury-Fridlyand Yury-Fridlyand changed the title Testing updated version of jackson-databind for only sql-jdbc Update version of jackson-databind for sql-jdbc only Oct 20, 2022
@dai-chen dai-chen added the dependencies Pull requests that update a dependency file label Oct 20, 2022
@dai-chen dai-chen added the JDBC label Oct 20, 2022
@dai-chen dai-chen merged commit 2c65ecb into opensearch-project:2.x Oct 20, 2022
@GumpacG GumpacG deleted the dev-fix-jackson-databind-cve branch October 20, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants