Fix NPE with multiple queries containing DOT(.) in index name. #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
joshuali925
previously approved these changes
Sep 29, 2022
joshuali925
reviewed
Sep 29, 2022
plugin/src/main/java/org/opensearch/sql/plugin/catalog/CatalogServiceImpl.java
Show resolved
Hide resolved
vamsimanohar
force-pushed
the
fix-#866
branch
from
d6e3355 to
e12f450
Compare
dai-chen
reviewed
Sep 29, 2022
integ-test/src/test/java/org/opensearch/sql/ppl/StandaloneIT.java
Outdated
Show resolved
Hide resolved
|
Could you change the title with more details? I think it will be used in release note at last. |
vamsimanohar
changed the title
vamsimanohar
changed the title
vamsimanohar
changed the title
Done. |
vamsimanohar
force-pushed
the
fix-#866
branch
from
e12f450 to
432fec9
Compare
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
vamsimanohar
force-pushed
the
fix-#866
branch
from
432fec9 to
9da8fb1
Compare
penghuo
approved these changes
Sep 30, 2022
vamsimanohar
added a commit
to vamsimanohar/sql
that referenced
this pull request
Sep 30, 2022
…earch-project#870) * Do not remove opensearch from the list of registered catalogs. Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> * New Changes to handle bug:opensearch-project#866 Signed-off-by: vamsi-amazon <reddyvam@amazon.com> Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: vamsi-amazon <reddyvam@amazon.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Oct 3, 2022
…earch-project#870) * Do not remove opensearch from the list of registered catalogs. Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> * New Changes to handle bug:opensearch-project#866 Signed-off-by: vamsi-amazon <reddyvam@amazon.com> Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: vamsi-amazon <reddyvam@amazon.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
GabeFernandez310
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Oct 19, 2022
…earch-project#870) * Do not remove opensearch from the list of registered catalogs. Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> * New Changes to handle bug:opensearch-project#866 Signed-off-by: vamsi-amazon <reddyvam@amazon.com> Signed-off-by: MaxKsyunz <maxk@bitquilltech.com> Signed-off-by: vamsi-amazon <reddyvam@amazon.com> Co-authored-by: MaxKsyunz <maxk@bitquilltech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the current implementation of CatalogServiceImpl, there is an NPE with multiple queries containing DOT in catalog name. More details in the below issue.
Issues Resolved
#866
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.