Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove opensearch.sql.engine.new.enabled setting #70

Merged
merged 5 commits into from
May 19, 2021

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented May 19, 2021

Signed-off-by: penghuo penghuo@gmail.com

Description

Remove the opensearch.sql.engine.new.enabled. The opensearch.sql.engine.new.enabled setting is added and set to default true on ODFE 1.13.0.0, the major purpose is to safely publish the new engine, in any case, the customer found issue, they still have the way to rollback to the legacy engine.
We didn't found major issue with new engine, so we decide to fullly enable it by default. If there are any case the new engine can't handle, it still fallback to the the legacy engine automatically. So, there is no impact for the customer.

Issues Resolved

#58

To Reviewers

The PR include the following changes

  1. Change the SQL entry point logic, the new engine is default now.
  2. Remove the integration test against the legacy engine.
  3. Ignore some IT which only work for legacy engine.
  4. Remove the opensearch.sql.engine.new.enabled related docs accordingly.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo penghuo requested review from dai-chen and chloe-zh May 19, 2021 02:43
@chloe-zh
Copy link
Contributor

@penghuo
Copy link
Collaborator Author

penghuo commented May 19, 2021

Signed-off-by: penghuo <penghuo@gmail.com>
… because there is no enough memory

Signed-off-by: penghuo <penghuo@gmail.com>
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable the legacy SQL/PPL Setting
3 participants