Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OS Version to 2.0.0-alpha1-SNAPSHOT #518

Merged
merged 5 commits into from
Mar 30, 2022

Conversation

vmmusings
Copy link
Member

@vmmusings vmmusings commented Mar 28, 2022

Signed-off-by: vamsi-amazon reddyvam@amazon.com

Description

Upgrade OpenSearch version to 2.0.0-alpha1-SNAPSHOT which has more changes corresponding to removal of mapping types.

Issues Resolved

#452
#485

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vmmusings vmmusings changed the title Upgraded to OS 2.0.0-alpah1-SNAPSHOT Upgrade OS Version to 2.0.0-alpha1-SNAPSHOT Mar 28, 2022
@vmmusings vmmusings requested a review from dai-chen March 29, 2022 19:16
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #518 (29ea632) into main (2dbfc18) will decrease coverage by 3.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #518      +/-   ##
============================================
- Coverage     98.40%   95.23%   -3.17%     
  Complexity     2744     2744              
============================================
  Files           266      276      +10     
  Lines          6752     7410     +658     
  Branches        419      537     +118     
============================================
+ Hits           6644     7057     +413     
- Misses          107      299     +192     
- Partials          1       54      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
workbench/public/components/Header/Header.tsx 100.00% <0.00%> (ø)
workbench/public/components/app.tsx 0.00% <0.00%> (ø)
workbench/public/components/PPLPage/PPLPage.tsx 56.52% <0.00%> (ø)
...ch/public/components/QueryResults/QueryResults.tsx 61.60% <0.00%> (ø)
...ublic/components/QueryResults/QueryResultsBody.tsx 68.32% <0.00%> (ø)
workbench/public/utils/PanelWrapper.tsx 100.00% <0.00%> (ø)
workbench/public/components/SQLPage/SQLPage.tsx 100.00% <0.00%> (ø)
workbench/public/application.tsx 0.00% <0.00%> (ø)
...h/public/components/QueryLanguageSwitch/Switch.tsx 85.71% <0.00%> (ø)
workbench/public/components/Main/main.tsx 53.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbfc18...29ea632. Read the comment docs.

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
@vmmusings vmmusings marked this pull request as ready for review March 29, 2022 22:17
@vmmusings vmmusings requested a review from a team as a code owner March 29, 2022 22:17
@vmmusings vmmusings requested a review from joshuali925 March 29, 2022 22:17
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments. FYI the workbench snapshots change should be ok for us, it's coming from dashboards core EUI library update

build.gradle Outdated Show resolved Hide resolved
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
joshuali925
joshuali925 previously approved these changes Mar 29, 2022
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmmusings vmmusings merged commit c6a7d3e into opensearch-project:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants