-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade OS Version to 2.0.0-alpha1-SNAPSHOT #518
Conversation
Codecov Report
@@ Coverage Diff @@
## main #518 +/- ##
============================================
- Coverage 98.40% 95.23% -3.17%
Complexity 2744 2744
============================================
Files 266 276 +10
Lines 6752 7410 +658
Branches 419 537 +118
============================================
+ Hits 6644 7057 +413
- Misses 107 299 +192
- Partials 1 54 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments. FYI the workbench snapshots change should be ok for us, it's coming from dashboards core EUI library update
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
legacy/src/main/java/org/opensearch/sql/legacy/esdomain/mapping/FieldMapping.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: vamsi-amazon reddyvam@amazon.com
Description
Upgrade OpenSearch version to 2.0.0-alpha1-SNAPSHOT which has more changes corresponding to removal of mapping types.
Issues Resolved
#452
#485
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.