Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.0.0] Remove SparkSQL support #3306

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Feb 6, 2025

Description

  • Remove SparkSQL support for v3.0.0
  • Removed spark module. A few classes are used by async-query-core and those are moved.

Related Issues

Resolves #3286

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@penghuo mentioned to keep spark module. Is there any necessity to remove?

@ykmr1224
Copy link
Collaborator Author

ykmr1224 commented Feb 6, 2025

@penghuo mentioned to keep spark module. Is there any necessity to remove?

Once removed the SparkSQL support, the remaining classes are used only by async-query-core. I didn't see necessity to keep this module.
@penghuo Can you give your thoughts?

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@ykmr1224 ykmr1224 changed the title Remove SparkSQL support [v3.0.0] Remove SparkSQL support Feb 7, 2025
@ykmr1224 ykmr1224 added the v3.0.0 label Feb 7, 2025
@penghuo
Copy link
Collaborator

penghuo commented Feb 7, 2025

@penghuo mentioned to keep spark module. Is there any necessity to remove?

Once removed the SparkSQL support, the remaining classes are used only by async-query-core. I didn't see necessity to keep this module. @penghuo Can you give your thoughts?

the remaining classes are used only by async-query-core?

the remaining classes means classed in Spark module? If yes, remove SparkSQL module will impact async-query?

@ykmr1224
Copy link
Collaborator Author

ykmr1224 commented Feb 7, 2025

the remaining classes means classed in Spark module? If yes, remove SparkSQL module will impact async-query?

Yes, remaining classes in spark module.
Following classes were dependency from async-query-core module, and I moved them from spark module to async-query-core in this PR.

  • SparkSqlFunctionResponseHandle
  • DefaultSparkSqlFunctionResponseHandle
  • SparkDataType
  • SparkExprValue

Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@dai-chen dai-chen merged commit 08a1899 into opensearch-project:main Feb 10, 2025
16 checks passed
@y3n11
Copy link

y3n11 commented Feb 13, 2025

Hi OpenSearch team,

I would like to better understand the implications of the removal of the SparkSQL connector. We are currently using OpenSearch along with PySpark in a production application, querying data with the library "opensearch-spark-30_2.12-1.3.0.jar" and spark.read.

Can we still use this approach with OpenSearch 3.0.0, or will we need to make changes?

Thank you in advance! @ykmr1224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SparkSQL supports for spark connector.
5 participants