Add other functions to SQL query validator #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykmr1224
force-pushed
the
uncategorized-functions
branch
from
f414ef9 to
3d69b56
Compare
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
ykmr1224
force-pushed
the
uncategorized-functions
branch
from
3d69b56 to
6722a2d
Compare
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
LantaoJin and
noCharger
as code owners
penghuo
reviewed
Feb 6, 2025
| @@ -422,6 +423,51 @@ public enum FunctionType { | |||
| "posexplode", | |||
| "posexplode_outer", | |||
| "stack")) | |||
| .put( | |||
| UNCATEGORIZED, | |||
There was a problem hiding this comment.
could u explain term "UNCATEGORIZED", why certain functions are classified as UNCATEGORIZED?
There was a problem hiding this comment.
Those functions were originally not covered since it was not listed in categorized list, but actually documented in full list. That's why I named it as uncategorized. (current categories are coming from the categorized list)
...c-query-core/src/main/java/org/opensearch/sql/spark/validator/SQLQueryValidationVisitor.java
Outdated
Show resolved
Hide resolved
...c-query-core/src/main/java/org/opensearch/sql/spark/validator/SQLQueryValidationVisitor.java
Show resolved
Hide resolved
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
|
Renamed |
ykmr1224
changed the title
penghuo
approved these changes
Feb 7, 2025
dai-chen
approved these changes
Feb 7, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
* Add uncategorized functions to SQL query validator Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Fix variable name Signed-off-by: Tomoyuki Morita <moritato@amazon.com> * Fix name from uncategorized to other Signed-off-by: Tomoyuki Morita <moritato@amazon.com> --------- Signed-off-by: Tomoyuki Morita <moritato@amazon.com> (cherry picked from commit 4b60ab6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224
pushed a commit
that referenced
this pull request
Feb 10, 2025
* Add uncategorized functions to SQL query validator * Fix variable name * Fix name from uncategorized to other --------- (cherry picked from commit 4b60ab6) Signed-off-by: Tomoyuki Morita <moritato@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Resolves #3237
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.