-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boolean function in PPL should be case insensitive #2758
Boolean function in PPL should be case insensitive #2758
Conversation
Signed-off-by: Lantao Jin <ltjin@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Thanks for your reviewing @penghuo @dai-chen @vamsi-amazon , will this PR be merged automatically? And backport PR will be triggered automatically either? Any action should I do next? |
@LantaoJin Could you confirm if the build issues are not because of your commit. I will merge all the approved PRs. |
None of current build issues caused by this code changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. I think you can merge from main
to fix CI now.
could u merge latest change from main and re-run test. |
Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit 956ec15) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 956ec15) Signed-off-by: Lantao Jin <ltjin@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…t#2758) Signed-off-by: Lantao Jin <ltjin@amazon.com>
…t#2758) Signed-off-by: Lantao Jin <ltjin@amazon.com>
Description
isnotnull()
works butISNOTNULL()
doesn't work in PPL.Issues Resolved
Resolve #2431
Check List
[ ] New functionality has been documented.[ ] New functionality has javadoc added[ ] New functionality has user manual doc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.