Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fail backport #1915

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Jul 31, 2023

Description

Adds to the workflow to add a "failed-backport" label on the PR if a backport fails. This will help us filter by those PRs which failed the backport and reconcile before release/for CVEs

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
@Yury-Fridlyand
Copy link
Collaborator

I tried this in #1009, we got no benefit from that.
@derek-ho could you please add more details to the PR? What was fixed? How?

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1915 (5c9769a) into main (31b2b28) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1915   +/-   ##
=========================================
  Coverage     97.42%   97.42%           
  Complexity     4647     4647           
=========================================
  Files           408      408           
  Lines         11526    11526           
  Branches        839      839           
=========================================
  Hits          11229    11229           
  Misses          290      290           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@derek-ho
Copy link
Collaborator Author

Adds to the workflow to add a "failed-backport" label on the PR if a backport fails. This will help us filter by those PRs which failed the backport and reconcile before release/for CVEs

@Yury-Fridlyand - edited the description. This adds to the workflow to add a "failed-backport" label on the PR if a backport fails. This will help us filter by those PRs which failed the backport and reconcile before release/for CVEs. Before hand, a backport would fail silently/not show any indication outside the PR that the backport failed.

@derek-ho derek-ho merged commit 89980bf into opensearch-project:main Aug 1, 2023
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 3, 2023
Signed-off-by: Derek Ho <dxho@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants