Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WeekOfYear Function To OpenSearch #1345

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Add WeekOfYear Function To OpenSearch #1345

merged 1 commit into from
Feb 16, 2023

Conversation

GabeFernandez310
Copy link
Contributor

Description

Adds the WeekOfYear function to the SQL plugin. It behaves like the week function which already exists in the new engine, and both are aligned with MySQL. It has been added as an alias.

Issues Resolved

722

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@GabeFernandez310
Add WeekOfYear Function To OpenSearch
e957173 
Added WeekOfYear As An Alias To Week Function

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
@GabeFernandez310 GabeFernandez310 requested a review from a team as a code owner February 15, 2023 17:15
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Feb 15, 2023
Closed
87 tasks
dai-chen
dai-chen approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@dai-chen dai-chen added the enhancement New feature or request label Feb 16, 2023
@Yury-Fridlyand Yury-Fridlyand merged commit 114e02a into opensearch-project:main Feb 16, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 16, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 16, 2023
@GabeFernandez310 @github-actions
Add WeekOfYear Function To OpenSearch (#1345)
a225a2b 
Added WeekOfYear As An Alias To Week Function

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 114e02a)
penghuo pushed a commit that referenced this pull request Feb 16, 2023
@opensearch-trigger-bot @GabeFernandez310
Add WeekOfYear Function To OpenSearch (#1345) (#1351)
b7a4deb 
Added WeekOfYear As An Alias To Week Function

Signed-off-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
(cherry picked from commit 114e02a)

Co-authored-by: GabeFernandez310 <Gabriel.Fernandez@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@dai-chen dai-chen dai-chen approved these changes

Assignees
No one assigned
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GabeFernandez310 @dai-chen @Yury-Fridlyand