Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing Confirmation] Confirm current testing requirements #1360

Closed
stephen-crawford opened this issue Feb 20, 2023 · 5 comments
Closed

[Testing Confirmation] Confirm current testing requirements #1360

stephen-crawford opened this issue Feb 20, 2023 · 5 comments
Labels
enhancement New feature or request infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Comments

@stephen-crawford
Copy link

stephen-crawford commented Feb 20, 2023

As part of the discussion around implementing an organization-wide testing policy, I am visiting each repo to see what tests they currently perform. I am conducting this work on GitHub so that it is easy to reference.

Looking at the SQL repository, it appears there is

Repository Unit Tests Integration Tests Backwards Compatibility Tests Additional Tests Link
SQL
  • Checkstyle, Jacoco (100% coverage required), Comparison Tests, Link checker, Certificate of Origin #1360

    If there are any tests I missed or anything you think all repositories in OpenSearch should have for testing please respond to this issue with details.

    @Yury-Fridlyand
    Copy link
    Collaborator

    The main CI workflow runs:

    • Unit tests
    • Integration tests
    • BWC tests
    • Checkstyle - code style verification
    • Jacoco - code coverage validation with 100% coverage requirement (there are exceptions for few files)
    • Doctests - validation of examples given in documentations
    • Comparison test - behavior validation compared with other databases (H2 and SQLite)

    @stephen-crawford
    Copy link
    Author

    Hi @Yury-Fridlyand, thank you for following up. I will adjust the notes for this to reflect what you run. For these tests do you feel any/all should be required across the organization?

    @Yury-Fridlyand
    Copy link
    Collaborator

    I think all java projects have checkstyle and jacoco.
    Other projects could have test coverage and code style provided by other tools (jacoco is java specific), but huge amount of work is needed to satisfy coverage/style requirements.

    @dai-chen dai-chen added infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. and removed untriaged labels Feb 21, 2023
    @stephen-crawford
    Copy link
    Author

    Thank you for the response, I will jot that down for the overall issue!

    @Swiddis
    Copy link
    Collaborator

    Swiddis commented Dec 19, 2024

    Looks like this is done -- reopen if needed

    @Swiddis Swiddis closed this as completed Dec 19, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    enhancement New feature or request infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants