Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deps]Update ml common dependency #529

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

Hailong-am
Copy link
Collaborator

Description

Replace ml-common-client to ml-common-common and ml-common-spi. We didn't use any class in client lib in skills, so it's safe to do this.

Related Issues

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am changed the title Update ml common dependency [Deps]Update ml common dependency Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (2b76e3c) to head (182fbe2).
Report is 51 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #529      +/-   ##
============================================
+ Coverage     81.78%   82.43%   +0.64%     
- Complexity      193      356     +163     
============================================
  Files            11       17       +6     
  Lines           961     1685     +724     
  Branches        137      240     +103     
============================================
+ Hits            786     1389     +603     
- Misses          121      203      +82     
- Partials         54       93      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinyual xinyual merged commit dc4925f into opensearch-project:main Feb 18, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants