-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the flaky test due to m_l_limit_exceeded_exception #150
Fix the flaky test due to m_l_limit_exceeded_exception #150
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=========================================
Coverage 81.73% 81.73%
Complexity 196 196
=========================================
Files 13 13
Lines 1002 1002
Branches 132 132
=========================================
Hits 819 819
Misses 133 133
Partials 50 50 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
…ponse logic Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
2557c9b
to
86c6593
Compare
associate PR: opensearch-project/ml-commons#1943 |
The CI workflows run 3 times and success all 3 times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: better to use git rebase -i
to reduce commits number and make main branch's commit compact
We will use |
Got it, just feel it's better to reflect the change from the PR and get it reviewed. |
* increase the CB threshold, delete model after test Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add log Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add wait time Signed-off-by: zhichao-aws <zhichaog@amazon.com> * enhancement: wait model undeploy before delete; refactor the wait response logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify ci yml Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> (cherry picked from commit 0791c34) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* increase the CB threshold, delete model after test * add log * add wait time * enhancement: wait model undeploy before delete; refactor the wait response logic * modify ci yml --------- (cherry picked from commit 0791c34) Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…oject#150) (opensearch-project#164) * increase the CB threshold, delete model after test * add log * add wait time * enhancement: wait model undeploy before delete; refactor the wait response logic * modify ci yml --------- (cherry picked from commit 0791c34) Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Description
In recent PRs there are flaky test due to m_l_limit_exceeded_exception.
error log:
"error":{"root_cause":[{"type":"m_l_limit_exceeded_exception","reason":"Memory Circuit Breaker is open, please check your resources!"}],"type":"m_l_limit_exceeded_exception","reason":"Memory Circuit Breaker is open, please check your resources!"},"status":500}
refThis PR fix the flaky test by incrase the threshold of
jvm_heap_memory_threshold
. Add delete model for integ tests if they have deployed one.Fix the node20 dependency issue by changing codecov to version 1.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.