Fix the flaky test due to m_l_limit_exceeded_exception #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhichao-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90 and
joshuali925
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=========================================
Coverage 81.73% 81.73%
Complexity 196 196
=========================================
Files 13 13
Lines 1002 1002
Branches 132 132
=========================================
Hits 819 819
Misses 133 133
Partials 50 50 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
…ponse logic Signed-off-by: zhichao-aws <zhichaog@amazon.com>
Signed-off-by: zhichao-aws <zhichaog@amazon.com>
zhichao-aws
force-pushed
the
fix_memory_flaky
branch
from
2557c9b
to
86c6593
Compare
|
associate PR: opensearch-project/ml-commons#1943 |
zhichao-aws
changed the title
|
The CI workflows run 3 times and success all 3 times. |
Hailong-am
approved these changes
Jan 30, 2024
mingshl
approved these changes
Jan 30, 2024
chishui
reviewed
Jan 31, 2024
We will use |
Got it, just feel it's better to reflect the change from the PR and get it reviewed. |
zane-neo
reviewed
Jan 31, 2024
zane-neo
approved these changes
Jan 31, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
* increase the CB threshold, delete model after test Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add log Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add wait time Signed-off-by: zhichao-aws <zhichaog@amazon.com> * enhancement: wait model undeploy before delete; refactor the wait response logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify ci yml Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> (cherry picked from commit 0791c34) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhichao-aws
pushed a commit
that referenced
this pull request
Jan 31, 2024
* increase the CB threshold, delete model after test * add log * add wait time * enhancement: wait model undeploy before delete; refactor the wait response logic * modify ci yml --------- (cherry picked from commit 0791c34) Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
…oject#150) (opensearch-project#164) * increase the CB threshold, delete model after test * add log * add wait time * enhancement: wait model undeploy before delete; refactor the wait response logic * modify ci yml --------- (cherry picked from commit 0791c34) Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In recent PRs there are flaky test due to m_l_limit_exceeded_exception.
error log:
"error":{"root_cause":[{"type":"m_l_limit_exceeded_exception","reason":"Memory Circuit Breaker is open, please check your resources!"}],"type":"m_l_limit_exceeded_exception","reason":"Memory Circuit Breaker is open, please check your resources!"},"status":500}refThis PR fix the flaky test by incrase the threshold of
jvm_heap_memory_threshold. Add delete model for integ tests if they have deployed one.Fix the node20 dependency issue by changing codecov to version 1.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.