Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add 'good' as a valid value for plugins.security.restapi.password_score_based_validation_strength #5120

Merged
merged 1 commit into from
Feb 20, 2025
Merged

[Backport 2.x] Add 'good' as a valid value for plugins.security.restapi.password_score_based_validation_strength #5120

merged 1 commit into from
Feb 20, 2025
+2 −1

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b20a09b from #5119.

@github-actions
Add 'good' as a valid value for plugins.security.restapi.password_sco…
c43437b 
…re_based_validation_strength (#5119)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit b20a09b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.24%. Comparing base (68eeb65) to head (c43437b).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #5120      +/-   ##
==========================================
- Coverage   68.25%   68.24%   -0.01%     
==========================================
  Files         346      346              
  Lines       24596    24597       +1     
  Branches     4067     4067              
==========================================
- Hits        16787    16786       -1     
- Misses       5885     5887       +2     
  Partials     1924     1924
Files with missing lines Coverage Δ
...curity/dlic/rest/validation/PasswordValidator.java 82.81% <100.00%> (+0.27%) ⬆️

... and 5 files with indirect coverage changes

@derek-ho derek-ho merged commit 0671ae8 into 2.x Feb 20, 2025
90 of 91 checks passed
@derek-ho derek-ho deleted the backport/backport-5119-to-2.x branch February 20, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derek-ho derek-ho derek-ho approved these changes

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@DarshitChanpura DarshitChanpura Awaiting requested review from DarshitChanpura DarshitChanpura is a code owner

@nibix nibix Awaiting requested review from nibix nibix is a code owner

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@RyanL1997 RyanL1997 Awaiting requested review from RyanL1997 RyanL1997 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@willyborankin willyborankin Awaiting requested review from willyborankin willyborankin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@derek-ho