-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Implement new extension points in IdentityPlugin and add ContextProvidingPluginSubject #5028
Merged
DarshitChanpura
merged 8 commits into
opensearch-project:2.x
from
cwperks:backport--4896-to-2.x
Jan 16, 2025
Merged
[Backport 2.x] Implement new extension points in IdentityPlugin and add ContextProvidingPluginSubject #5028
DarshitChanpura
merged 8 commits into
opensearch-project:2.x
from
cwperks:backport--4896-to-2.x
Jan 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dingPluginSubject (opensearch-project#4896) Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 1924e41)
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
5 tasks
codecov is not picking up on lines hit through the integration tests for this change. |
5 tasks
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Pushed a commit to backport #4802 in this PR as well. |
willyborankin
previously approved these changes
Jan 16, 2025
Signed-off-by: Craig Perkins <cwperx@amazon.com>
DarshitChanpura
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #4896 to 2.x and target the new style authorization code path. A separate PR will be raised to implement this with the legacy authorization code path.
Also backports #4802 to resolve issues with codecov not reporting lines covered by tests in the
integrationTest
sourceSet.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.