Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for certificates hot reload #4880

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

willyborankin
Copy link
Collaborator

Description

Added support for certificates hot reload

Issues Resolved

#4427

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 74.35897% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.42%. Comparing base (9b67d54) to head (b1f826c).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...rg/opensearch/security/ssl/SslSettingsManager.java 79.31% 6 Missing ⚠️
.../opensearch/security/OpenSearchSecurityPlugin.java 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4880      +/-   ##
==========================================
- Coverage   71.45%   71.42%   -0.03%     
==========================================
  Files         334      334              
  Lines       22509    22543      +34     
  Branches     3582     3586       +4     
==========================================
+ Hits        16084    16102      +18     
- Misses       4633     4645      +12     
- Partials     1792     1796       +4     
Files with missing lines Coverage Δ
...org/opensearch/security/ssl/SslContextHandler.java 98.87% <100.00%> (+0.03%) ⬆️
...g/opensearch/security/support/ConfigConstants.java 95.23% <ø> (ø)
.../opensearch/security/OpenSearchSecurityPlugin.java 83.56% <33.33%> (-0.45%) ⬇️
...rg/opensearch/security/ssl/SslSettingsManager.java 71.59% <79.31%> (-0.41%) ⬇️

... and 5 files with indirect coverage changes

---- 🚨 Try these New Features:

@cwperks
Copy link
Member

cwperks commented Nov 7, 2024

@willyborankin Can you open a documentation PR for this as well since this adds a new setting?

Added support for certificates hot reload
issue: 4427

Signed-off-by: Andrey Pleskach <ples@aiven.io>
@cwperks cwperks added the v2.19.0 Issues targeting release v2.19.0 label Nov 25, 2024
@willyborankin willyborankin merged commit c22002a into opensearch-project:main Nov 25, 2024
41 of 43 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4880-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c22002a5313fa2cc265b43c2177ecc2357ad0701
# Push it to GitHub
git push --set-upstream origin backport/backport-4880-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4880-to-2.x.

willyborankin added a commit to willyborankin/security that referenced this pull request Nov 25, 2024
Signed-off-by: Andrey Pleskach <ples@aiven.io>
(cherry picked from commit c22002a)
willyborankin added a commit to willyborankin/security that referenced this pull request Nov 25, 2024
…oject#4880)

Signed-off-by: Andrey Pleskach <ples@aiven.io>
(cherry picked from commit c22002a)
@willyborankin willyborankin deleted the ssl-hot-reload branch January 2, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch backport-failed v2.19.0 Issues targeting release v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants