-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for certificates hot reload #4880
Add support for certificates hot reload #4880
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4880 +/- ##
==========================================
- Coverage 71.45% 71.42% -0.03%
==========================================
Files 334 334
Lines 22509 22543 +34
Branches 3582 3586 +4
==========================================
+ Hits 16084 16102 +18
- Misses 4633 4645 +12
- Partials 1792 1796 +4
|
@willyborankin Can you open a documentation PR for this as well since this adds a new setting? |
src/main/java/org/opensearch/security/OpenSearchSecurityPlugin.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/security/ssl/SslSettingsManagerReloadListenerTest.java
Show resolved
Hide resolved
Added support for certificates hot reload issue: 4427 Signed-off-by: Andrey Pleskach <ples@aiven.io>
f6c992c
to
b1f826c
Compare
c22002a
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4880-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c22002a5313fa2cc265b43c2177ecc2357ad0701
# Push it to GitHub
git push --set-upstream origin backport/backport-4880-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
Signed-off-by: Andrey Pleskach <ples@aiven.io> (cherry picked from commit c22002a)
…oject#4880) Signed-off-by: Andrey Pleskach <ples@aiven.io> (cherry picked from commit c22002a)
Description
Added support for certificates hot reload
Issues Resolved
#4427
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.