Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when a node with an incorrectly configured certificate attempts to connect #4818

Merged

Conversation

akolarkunnu
Copy link
Contributor

@akolarkunnu akolarkunnu commented Oct 17, 2024

Description

Updated the error message to understand what is the exact reason of error and renamed the API name to match the intention of API.

Issues Resolved

Resolves #4601

Testing

Ran the unit tests

Check List

  • [ x] New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • [ x] API changes companion pull request created
  • [ x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ificate attempts to connect

Updated the error message to understand what is the exact reason and renamed the API name to match the intention of API.

Resolves opensearch-project#4601

Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
@akolarkunnu
Copy link
Contributor Author

This is breaking change because of renaming of API. When I backport this, I will keep the existing API as such and introduce this as a new API, so that it won't break anything.

@akolarkunnu
Copy link
Contributor Author

Can anyone please approve to start workflow(test execution) ?

…ificate attempts to connect

Updated the error message to understand what is the exact reason and renamed the API name to match the intention of API.

Resolves opensearch-project#4601

Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
@peternied peternied added the backport 2.x backport to 2.x branch label Oct 17, 2024
…ificate attempts to connect

Updated the error message to understand what is the exact reason and renamed the API name to match the intention of API.

Resolves opensearch-project#4601

Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
nibix
nibix previously approved these changes Oct 18, 2024
@willyborankin
Copy link
Collaborator

@akolarkunnu, could you please fix code formatting? (gradle spotlessCheck spotlessApply)

…ificate attempts to connect

Updated the error message to understand what is the exact reason and renamed the API name to match the intention of API.

Resolves opensearch-project#4601

Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
@akolarkunnu
Copy link
Contributor Author

@akolarkunnu, could you please fix code formatting? (gradle spotlessCheck spotlessApply)

Fixed the formatting. I feel it's good to list all Code Hygiene checks in the Developer Guide as a pre-commit activity, so that new comers will do that before creating the PR.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.75%. Comparing base (7692d77) to head (9ecd5f4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4818      +/-   ##
==========================================
+ Coverage   70.71%   70.75%   +0.04%     
==========================================
  Files         310      310              
  Lines       20938    20938              
  Branches     3326     3326              
==========================================
+ Hits        14806    14815       +9     
+ Misses       4384     4377       -7     
+ Partials     1748     1746       -2     
Files with missing lines Coverage Δ
...g/opensearch/security/ssl/util/ExceptionUtils.java 52.17% <100.00%> (ø)
...rch/security/transport/SecurityRequestHandler.java 55.03% <100.00%> (ø)

... and 2 files with indirect coverage changes

@willyborankin
Copy link
Collaborator

@nibix could you plz aprrove it one more time and I will merge it

@willyborankin willyborankin merged commit e0fb8fc into opensearch-project:main Oct 18, 2024
42 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2024
…ificate attempts to connect (#4818)

Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
(cherry picked from commit e0fb8fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve error message when a node with an incorrectly configured certificate attempts to connect
5 participants