-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message when a node with an incorrectly configured certificate attempts to connect #4818
Improve error message when a node with an incorrectly configured certificate attempts to connect #4818
Conversation
…ificate attempts to connect Updated the error message to understand what is the exact reason and renamed the API name to match the intention of API. Resolves opensearch-project#4601 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
This is breaking change because of renaming of API. When I backport this, I will keep the existing API as such and introduce this as a new API, so that it won't break anything. |
Can anyone please approve to start workflow(test execution) ? |
…ificate attempts to connect Updated the error message to understand what is the exact reason and renamed the API name to match the intention of API. Resolves opensearch-project#4601 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
src/main/java/org/opensearch/security/ssl/util/ExceptionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/ssl/util/ExceptionUtils.java
Outdated
Show resolved
Hide resolved
…ificate attempts to connect Updated the error message to understand what is the exact reason and renamed the API name to match the intention of API. Resolves opensearch-project#4601 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
@akolarkunnu, could you please fix code formatting? ( |
…ificate attempts to connect Updated the error message to understand what is the exact reason and renamed the API name to match the intention of API. Resolves opensearch-project#4601 Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
Fixed the formatting. I feel it's good to list all Code Hygiene checks in the Developer Guide as a pre-commit activity, so that new comers will do that before creating the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4818 +/- ##
==========================================
+ Coverage 70.71% 70.75% +0.04%
==========================================
Files 310 310
Lines 20938 20938
Branches 3326 3326
==========================================
+ Hits 14806 14815 +9
+ Misses 4384 4377 -7
+ Partials 1748 1746 -2
|
@nibix could you plz aprrove it one more time and I will merge it |
Description
Updated the error message to understand what is the exact reason of error and renamed the API name to match the intention of API.
Issues Resolved
Resolves #4601
Testing
Ran the unit tests
Check List
New functionality has been documentedNew Roles/Permissions have a corresponding security dashboards plugin PRBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.