Refactor Roles REST API test and partial fix #4166

[willyborankin]

Description

Refactor Roles REST API test

Issues Resolved

partial fix #4166

Check List

• New functionality includes testing
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.23%. Comparing base (439606c) to head (a88c04e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4433      +/-   ##
==========================================
- Coverage   65.24%   65.23%   -0.01%     
==========================================
  Files         312      312              
  Lines       22032    22032              
  Branches     3558     3558              
==========================================
- Hits        14374    14372       -2     
- Misses       5888     5890       +2     
  Partials     1770     1770              

Files	Coverage Δ
...nsearch/security/dlic/rest/api/RolesApiAction.java	98.03% <100.00%> (+0.08%)	⬆️
...g/opensearch/security/dlic/rest/support/Utils.java	59.45% <100.00%> (-1.07%)	⬇️

... and 3 files with indirect coverage changes

[cwperks]

LGTM. Thank you @willyborankin. Thank you for verifying that the new integ test covers the same scenarios as the old integ tests. Its good to see that the coverage goes slightly up and the new code introduced in this PR to allow superadmin to update with "hidden" is also covered.

[DarshitChanpura]

@willyborankin I see some overlap with #4450. Should we combine these into 1 PR?

[willyborankin]

@willyborankin I see some overlap with #4450. Should we combine these into 1 PR?

@DarshitChanpura, Yes I tested #4450 with internal-test fixes I added in this PR. So this one should be merged first.

[DarshitChanpura]

LGTM!

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4433-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 962eafab80fac3064de02b76bc956ee031703e0e
# Push it to GitHub
git push --set-upstream origin backport/backport-4433-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4433-to-2.x.