Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.8] Separate config option to enable restapi: permissions (#2605) #2818

Conversation

DarshitChanpura
Copy link
Member

Backports #2605 to 2.8

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ject#2605)

Added config settings
plugins.security.restapi.admin.enabled which enables/disables :resapi permissions.
Default is false

Signed-off-by: Andrey Pleskach <ples@aiven.io>
(cherry picked from commit 6446268)
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #2818 (3b854dd) into 2.8 (2ebcfa7) will decrease coverage by 0.11%.
The diff coverage is 53.33%.

@@             Coverage Diff              @@
##                2.8    #2818      +/-   ##
============================================
- Coverage     61.44%   61.34%   -0.11%     
+ Complexity     3376     3369       -7     
============================================
  Files           264      264              
  Lines         18631    18637       +6     
  Branches       3283     3285       +2     
============================================
- Hits          11447    11432      -15     
- Misses         5603     5618      +15     
- Partials       1581     1587       +6     
Impacted Files Coverage Δ
...security/dlic/rest/api/SecuritySSLCertsAction.java 71.13% <ø> (-0.59%) ⬇️
...g/opensearch/security/support/ConfigConstants.java 94.44% <ø> (ø)
...dlic/rest/api/RestApiAdminPrivilegesEvaluator.java 75.75% <41.66%> (-2.58%) ⬇️
.../opensearch/security/OpenSearchSecurityPlugin.java 80.23% <100.00%> (+0.03%) ⬆️
...arch/security/dlic/rest/api/AbstractApiAction.java 75.96% <100.00%> (+0.09%) ⬆️

... and 6 files with indirect coverage changes

@RyanL1997 RyanL1997 merged commit 570d617 into opensearch-project:2.8 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants