Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVE-2023-25806] [Backport 2.6] Flatten response times #2472

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

stephen-crawford
Copy link
Collaborator

Description

Manually backport reponse time flattening for 2.6 release

Testing

Includes InternalAuthBackendTests.java test file.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@stephen-crawford
Copy link
Collaborator Author

The whitesource is a known issue that we are still waiting for a fix from the dependency provider.

@cwperks cwperks changed the title [Backport] Flatten response times [Backport 2.6] Flatten response times Feb 22, 2023
@cwperks
Copy link
Member

cwperks commented Feb 22, 2023

Last windows CI failure was flaky. Merging this now to unblock the release train. There is no platform specific logic in this PR and the other checks have passed. The team will ensure that CI for the failing check on windows with JDK 17 passes post merge.

@cwperks cwperks merged commit d6d7c78 into opensearch-project:2.6 Feb 22, 2023
@stephen-crawford
Copy link
Collaborator Author

Thank you @cwperks

@peternied peternied changed the title [Backport 2.6] Flatten response times [CVE-2023-25806] [Backport 2.6] Flatten response times Mar 1, 2023
@stephen-crawford stephen-crawford deleted the flatten-2.6 branch March 2, 2023 15:00
@AndreVirtimo
Copy link

Thank you for fixing this issue.

Can anyone tell my why the related advisory is not visible in the advisory database ( https://github.com/advisories)? I also have looked for unreviewed advisories.

Because of this our security management system has no access to this advisory.

The CVE-2023-25806 has no CPEs attached, so our system can't match the CVE to OpenSearch. Is it possible to provide CPEs to the CVE?

@DarshitChanpura
Copy link
Member

@AndreVirtimo Thank you for reaching out. Looks like the NVD is still analyzing the CVE and it might take few more days before it appears on the advisory database. You can monitor here: https://nvd.nist.gov/vuln/detail/CVE-2023-25806

@peternied
Copy link
Member

@AndreVirtimo Our advisory for this issue is available here - while waiting on the NVD analysis does that cover what you are looking for?

@AndreVirtimo
Copy link

@peternied I know that the advisory is there. This was my first contact with the issue. I wondered why the advisory was not in our mirror of Github Advisories.

In this project I can see 5 advisories. 3 of them are also listed here. The advisories GHSA-wmx7-x4jp-9jgg and GHSA-c6wg-cm5x-rqvj are not in this database. Is there a need to publish this advisories to the database?

I wish to find all advisories in the Github database. Because we are scanning this database to detect possible vulnerabilities.

@DarshitChanpura
Copy link
Member

DarshitChanpura commented Mar 7, 2023

@AndreVirtimo The advisory is now visible on the database: https://github.com/advisories?query=CVE-2023-25806

Screenshot 2023-03-07 at 1 09 01 PM

@AndreVirtimo
Copy link

@DarshitChanpura thank you. I can now also see the advisory in our security scanner.

Did you have to explicitly publish the advisory or what was the issue?

@DarshitChanpura
Copy link
Member

Did you have to explicitly publish the advisory or what was the issue?

The advisory wasn't connected to the Maven artifact, which caused Github to not pick it up correctly.

wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants