-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the default role for IM plugin #1427
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1427 +/- ##
============================================
+ Coverage 64.83% 64.85% +0.01%
- Complexity 3217 3218 +1
============================================
Files 247 247
Lines 17278 17278
Branches 3057 3057
============================================
+ Hits 11203 11205 +2
+ Misses 4525 4524 -1
+ Partials 1550 1549 -1
Continue to review full report at Codecov.
|
securityconfig/roles.yml
Outdated
- "cluster:admin/opendistro/ism/managedindex/change" | ||
- "cluster:admin/opendistro/ism/managedindex/retry" | ||
- "cluster:admin/opendistro/ism/managedindex/explain" | ||
- "cluster:admin/opendistro/rollup/index" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't these rollup and transform be a part of ISM plugin and should have same path as of policy and mangedindex ?
ideally it should be like .. ism/rollup
and ism/transform
same as ism/policy
and ism/managedindex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The format followed so far is opendistro/<feature>/...
created an issue in IndexManagement - opensearch-project/index-management#138
rebase against |
edd0aed
to
3a86317
Compare
Signed-off-by: Ravi Thaluru <ravi1092@gmail.com>
Signed-off-by: Ravi Thaluru <ravi1092@gmail.com>
Signed-off-by: Ravi Thaluru <ravi1092@gmail.com>
Signed-off-by: Ravi Thaluru ravi1092@gmail.com
opensearch-security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly
Adding a new full access role for IndexManagement plugin so users who want to manage all indices, create policies, create rollups, create transforms can use the deafult role.
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.