Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the default role for IM plugin #1427

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

thalurur
Copy link
Contributor

Signed-off-by: Ravi Thaluru ravi1092@gmail.com

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly
Adding a new full access role for IndexManagement plugin so users who want to manage all indices, create policies, create rollups, create transforms can use the deafult role.

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@thalurur thalurur requested a review from a team August 25, 2021 22:10
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #1427 (55dfe23) into main (4b16644) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1427      +/-   ##
============================================
+ Coverage     64.83%   64.85%   +0.01%     
- Complexity     3217     3218       +1     
============================================
  Files           247      247              
  Lines         17278    17278              
  Branches       3057     3057              
============================================
+ Hits          11203    11205       +2     
+ Misses         4525     4524       -1     
+ Partials       1550     1549       -1     
Impacted Files Coverage Δ
...a/org/opensearch/security/tools/SecurityAdmin.java 47.52% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b16644...55dfe23. Read the comment docs.

hardik-k-shah
hardik-k-shah previously approved these changes Aug 26, 2021
hardik-k-shah
hardik-k-shah previously approved these changes Sep 2, 2021
- "cluster:admin/opendistro/ism/managedindex/change"
- "cluster:admin/opendistro/ism/managedindex/retry"
- "cluster:admin/opendistro/ism/managedindex/explain"
- "cluster:admin/opendistro/rollup/index"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't these rollup and transform be a part of ISM plugin and should have same path as of policy and mangedindex ?

ideally it should be like .. ism/rollup and ism/transform same as ism/policy and ism/managedindex

Copy link
Contributor Author

@thalurur thalurur Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format followed so far is opendistro/<feature>/... created an issue in IndexManagement - opensearch-project/index-management#138

securityconfig/roles.yml Outdated Show resolved Hide resolved
@vrozov
Copy link
Contributor

vrozov commented Sep 3, 2021

rebase against main and sign commit.

@thalurur thalurur force-pushed the main branch 2 times, most recently from edd0aed to 3a86317 Compare September 3, 2021 18:12
Signed-off-by: Ravi Thaluru <ravi1092@gmail.com>
@hardik-k-shah hardik-k-shah merged commit 99e1571 into opensearch-project:main Sep 3, 2021
lbreinig pushed a commit to lbreinig/security that referenced this pull request Dec 23, 2021
Signed-off-by: Ravi Thaluru <ravi1092@gmail.com>
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Signed-off-by: Ravi Thaluru <ravi1092@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants