Fix maven build ${version} deprecation warning #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase and resolve conflicts |
cjcjameson
force-pushed
the
mvn-project-warning
branch
from
53d725c to
31f7c79
Compare
|
@vrozov rebased |
Codecov Report
@@ Coverage Diff @@
## main #1209 +/- ##
=========================================
Coverage 64.75% 64.75%
- Complexity 3194 3195 +1
=========================================
Files 247 247
Lines 17232 17232
Branches 3046 3046
=========================================
Hits 11159 11159
Misses 4523 4523
Partials 1550 1550 Continue to review full report at Codecov.
|
cliu123
previously approved these changes
Jul 14, 2021
|
@cjcjameson Would you please sign the commit and push it one more time? |
cjcjameson
force-pushed
the
mvn-project-warning
branch
from
31f7c79 to
6d0759a
Compare
cliu123
previously approved these changes
Jul 15, 2021
vrozov
previously approved these changes
Jul 18, 2021
|
@vrozov all set for you to merge |
vrozov
reviewed
Jul 19, 2021
cjcjameson
force-pushed
the
mvn-project-warning
branch
from
6d0759a to
36e829f
Compare
`mvn package` warns...
[WARNING] Some problems were encountered while building the effective model for org.opensearch:opensearch-security:jar:1.0.0.0-rc1
[WARNING] The expression ${version} is deprecated. Please use ${project.version} instead.
[WARNING] The expression ${version} is deprecated. Please use ${project.version} instead.
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
Signed-off-by: C.J. Jameson <cjcjameson@gmail.com>
cjcjameson
force-pushed
the
mvn-project-warning
branch
from
36e829f to
494db0a
Compare
|
Re-running CI system. Failure seems unrelated. |
vrozov
changed the title
vrozov
approved these changes
Jul 20, 2021
cliu123
approved these changes
Jul 20, 2021
|
@cliu123 can you be the one to merge? I cannot. |
AMoo-Miki
pushed a commit
to AMoo-Miki/security
that referenced
this pull request
Aug 13, 2021
lbreinig
pushed a commit
to lbreinig/security
that referenced
this pull request
Dec 23, 2021
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: C.J. Jameson cjcjameson@gmail.com
opensearch-security pull request intake form
maintenance
n/a
mvn packagewarns...[WARNING] Some problems were encountered while building the effective model for org.opensearch:opensearch-security:jar:1.0.0.0-rc1
[WARNING] The expression ${version} is deprecated. Please use ${project.version} instead.
[WARNING] The expression ${version} is deprecated. Please use ${project.version} instead.
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
make it easier to upgrade pom.xml dependencies
What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)
Is it backport from main branch? (If yes, please add backport PR # and commits #)
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.