Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to rc1, create release notes and fix the url used in release notes drafter #1186

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented May 26, 2021

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Maintenance

  2. Github Issue # or road-map entry, if available:

  3. Description of changes:

  • Bump plugin version to 1.0.0.0-rc1
  • Create release notes for 1.0.0.0-rc1
  • Fix the url used in release notes drafter
  1. Why these changes are required?
    1.0.0.0-rc1 Release

  2. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
    No changes in behavior

  3. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
    UT

  4. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

  5. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cliu123 cliu123 added the maintenance Project maintenance label May 26, 2021
@cliu123 cliu123 marked this pull request as draft May 26, 2021 01:39
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #1186 (7a35d4e) into main (d3f2f98) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1186      +/-   ##
============================================
- Coverage     64.61%   64.49%   -0.13%     
+ Complexity     3174     3170       -4     
============================================
  Files           244      245       +1     
  Lines         17125    17128       +3     
  Branches       3036     3035       -1     
============================================
- Hits          11066    11046      -20     
- Misses         4515     4542      +27     
+ Partials       1544     1540       -4     
Impacted Files Coverage Δ
...org/opensearch/security/rest/TenantInfoAction.java 77.61% <0.00%> (-10.45%) ⬇️
...pensearch/security/auditlog/impl/AuditMessage.java 73.57% <0.00%> (-7.78%) ⬇️
...earch/security/auditlog/impl/AbstractAuditLog.java 74.93% <0.00%> (-0.80%) ⬇️
...g/opensearch/security/ssl/transport/SSLConfig.java 90.00% <0.00%> (-0.48%) ⬇️
...arch/security/ssl/OpenSearchSecuritySSLPlugin.java 83.97% <0.00%> (-0.47%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 47.39% <0.00%> (-0.14%) ⬇️
...g/opensearch/security/support/ConfigConstants.java 94.44% <0.00%> (ø)
.../opensearch/security/support/SecuritySettings.java 66.66% <0.00%> (ø)
.../opensearch/security/OpenSearchSecurityPlugin.java 81.22% <0.00%> (+0.07%) ⬆️
...security/configuration/DlsFlsFilterLeafReader.java 60.47% <0.00%> (+0.70%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f2f98...7a35d4e. Read the comment docs.

build.gradle Outdated Show resolved Hide resolved
@cliu123 cliu123 marked this pull request as ready for review May 26, 2021 21:47
@cliu123 cliu123 requested review from a team, sujithvm, vrozov, camerski and peterzhuamazon May 26, 2021 21:47
@cliu123 cliu123 merged commit c245089 into opensearch-project:main May 27, 2021
@cliu123 cliu123 deleted the bump_version_to_rc1_and_create_release_notes branch May 27, 2021 03:48
lbreinig pushed a commit to lbreinig/security that referenced this pull request Dec 23, 2021
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants