Build plugin on top of 1.x branch of OpenSearch core

[cliu123]

opendistro-for-elasticsearch/security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
   Maintenance

2. Github Issue # or road-map entry, if available:

3. Description of changes:
   Build security plugin on top of 1.x branch.

4. Why these changes are required?
   The 1.x is the stable branch with new fixes on OpenSearch core.

5. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)
   No changes in behavior

6. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)
   UT

7. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

8. Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[andy840314]

This is the requirement for settings migration to OpenSearch.

[codecov-commenter]

Codecov Report

Merging #1174 (54a0071) into main (4c182a2) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1174      +/-   ##
============================================
- Coverage     64.56%   64.48%   -0.08%     
+ Complexity     3170     3167       -3     
============================================
  Files           244      244              
  Lines         17124    17124              
  Branches       3036     3036              
============================================
- Hits          11056    11043      -13     
- Misses         4527     4539      +12     
- Partials       1541     1542       +1     

Impacted Files	Coverage Δ	Complexity Δ
...org/opensearch/security/rest/TenantInfoAction.java	77.61% <0.00%> (-10.45%)	15.00% <0.00%> (ø%)
...security/auditlog/AuditLogSslExceptionHandler.java	33.33% <0.00%> (-9.53%)	3.00% <0.00%> (-1.00%)
...urity/ssl/transport/SecuritySSLNettyTransport.java	62.76% <0.00%> (-6.39%)	4.00% <0.00%> (-1.00%)
...pensearch/security/auditlog/impl/AuditLogImpl.java	88.88% <0.00%> (-1.12%)	43.00% <0.00%> (-1.00%)
...security/configuration/DlsFlsFilterLeafReader.java	60.47% <0.00%> (+0.70%)	64.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c182a2...54a0071. Read the comment docs.

[dblock]

Does this run integration tests? I think it should be using the version qualifier of -rc1 once there's an artifact and rn that would fail?

[cliu123]

Does this run integration tests? I think it should be using the version qualifier of -rc1 once there's an artifact and rn that would fail?

@dblock Security plugin replies on UTs, not IT. I applied the similar change as job-scheduler did. Do you mean we can go with this change and will need to add -rc1 once the core artifacts are ready?

[dblock]

Does this run integration tests? I think it should be using the version qualifier of -rc1 once there's an artifact and rn that would fail?

@dblock Security plugin replies on UTs, not IT. I applied the similar change as job-scheduler did. Do you mean we can go with this change and will need to add -rc1 once the core artifacts are ready?

Yes. I just don't want you to forget.