Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Should system index permissions check allow access to system indices with .* pattern? #3259

Closed
Tracked by #2529
DarshitChanpura opened this issue Aug 29, 2023 · 4 comments
Labels
question User requested information untriaged Require the attention of the repository maintainers and may need to be prioritized

Comments

@DarshitChanpura
Copy link
Member

DarshitChanpura commented Aug 29, 2023

The system index permissions check introduced via #2887 adds check for * and <prefix>*.

Access to all system indices is currently not allowed with *. A prefix is required to granted access to all system indices matching that prefix.

With <prefix>* pattern, access will be granted to all indices (including system indices) that begin with a dot ..

Currently all system indices reserved by plugins (see the list here) begin with a ., this would essentially make * pattern access control ineffective.

The goal of this issue is to seek votes whether to allow access to system indices with .* pattern.

@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Aug 29, 2023
@DarshitChanpura DarshitChanpura added the question User requested information label Aug 29, 2023
@DarshitChanpura
Copy link
Member Author

The proposal is to also block access to system indices when index pattern is provided as .*.

Please vote 👍 (do not allow access with .* pattern) or 👎 (to keep as is, and allow access to system index with .* pattern)

@peternied
Copy link
Member

👎 We are discussing the API surface area which should have a crystal clear definition for well formed. We don't have verification like this is any other security config definitions, it is a new precedence if we add special cases like this.

Handling specials cases such as this in the Dashboards UX to where we could add a warning message - might be a place we can help administrators make informed decisions.

@davidlago
Copy link

This ☝️ and in the docs. The dot notation affords no special protections, it is just a convention.

@DarshitChanpura
Copy link
Member Author

After engaging in internal discussion, the answer to this question is:

We will not add extra checks for .* patterns. However this will be documented to the customers to proceed with caution via opensearch-project/documentation-website#4849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question User requested information untriaged Require the attention of the repository maintainers and may need to be prioritized
Projects
None yet
Development

No branches or pull requests

3 participants