Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] System Indices access for Extensions #2529

Closed
8 of 9 tasks
peternied opened this issue Mar 8, 2023 · 9 comments
Closed
8 of 9 tasks

[META] System Indices access for Extensions #2529

peternied opened this issue Mar 8, 2023 · 9 comments
Assignees
Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. v2.10.0 Issues targeting release v2.10.0

Comments

@peternied
Copy link
Member

peternied commented Mar 8, 2023

OpenSearch plugins utilize system indexes to store information that persists through the cluster, such as the security configuration for the Security Plugin or .replication-metadata-store indexes for cross cluster replication. These indexes contain data specific to the plugin and should not be altered by any other plugin or application.

This meta issue is tracking what associated work needs to be done

Design

Implementation

Questions

Release

Future Investment

@peternied peternied self-assigned this Mar 8, 2023
@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Mar 8, 2023
@peternied peternied removed the untriaged Require the attention of the repository maintainers and may need to be prioritized label Mar 13, 2023
@peternied
Copy link
Member Author

Option 2b: Extension service account, scoped to specific system index [Recommended] is best aligned based on the current considerations and discussion topic. I'll add associated work to this meta issue.

@peternied
Copy link
Member Author

@opensearch-project/security I've added work items for this META issue, please review the tasks on this item and if we need any more detail.

Small note; I did not create an issue for the documentation because I think we should create the task on the documentation-website by whoever will own that work when its ready.

@stephen-crawford stephen-crawford added the triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. label Mar 20, 2023
@peternied peternied removed their assignment Mar 31, 2023
@cwperks
Copy link
Member

cwperks commented Apr 1, 2023

I wanted to leave an additional comment here. I'm starting not to love the term system indices in this context. IMO System Indices are indices critical for OpenSearch to run. These indices deserve special protection and are critical for an extension to run, but should we keep utilizing the term system index?

I've started calling these reserved indices as the extension would like to reserve these indices for it to store data its needs to function properly. Any thoughts on the naming?

Its important to note that many plugins utilize system index protection provided by the security plugin without explicitly being a system index by implementing SystemIndexPlugin.

@samuelcostae
Copy link
Contributor

samuelcostae commented Apr 4, 2023

I agree with your point @cwperks , though I lack end user viewpoint, what made me agree with you is that from a code structure point of view, the issue became much clearer to me once i considered these "Extension Indicices" as a different category from the "protected/system Indices" that already exist in the SecurityIndexAccessEvaluator class

@peternied
Copy link
Member Author

'System index' is the name of the feature in OpenSearch so we seem pretty locked in. I'm open to alternative names, when I think of 'extension index' / 'protected index' or something, it would be implemented differently without the relationship to SystemIndexPlugin which is a requirement for backward compatibility with the existing plugins.

@DarshitChanpura
Copy link
Member

@peternied Can we mark this issue as closed for 2.10?

@peternied
Copy link
Member Author

@DarshitChanpura I still see tasks that are incomplete, seems like we shouldn't close it. What do you think?

@DarshitChanpura
Copy link
Member

@peternied
Copy link
Member Author

@DarshitChanpura thanks for creating the other tracking issue, I'm going to consider this one resolved and we can us that seperate issue for tracking what might be needed for extensions release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. v2.10.0 Issues targeting release v2.10.0
Projects
Status: 2.10.0 (Launched)
Status: Done
Development

No branches or pull requests

5 participants