Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bwcTests failing with Caused by: java.lang.ClassNotFoundException: org.opensearch.core.common.settings.SecureString #3020

Closed
cwperks opened this issue Jul 17, 2023 · 2 comments
Closed

bwcTests failing with Caused by: java.lang.ClassNotFoundException: org.opensearch.core.common.settings.SecureString #3020

cwperks opened this issue Jul 17, 2023 · 2 comments
Assignees
@cwperks
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@cwperks
Copy link
Member

cwperks commented Jul 17, 2023

bwcTests have been failing on the build fixing PR: #3003

Example: https://github.com/opensearch-project/security/actions/runs/5577024281/jobs/10193085379

The class that the build is complaining about SecureString was moved packages in a PR that was merged last week. The code in the PR compiles which indicates that the code fix had worked, but it fails to run the 3.0.0 node during backwards compatibility testing.

I suspect that it is downloading a stale distribution build that you can see here:

Failed to get resource: HEAD. [HTTP HTTP/1.1 403 Forbidden: https://artifacts.opensearch.org/releases/core/opensearch/3.0.0/opensearch-min-3.0.0-linux-x64.tar.gz)]
Downloading https://artifacts.opensearch.org/release-candidates/core/opensearch/3.0.0/opensearch-min-3.0.0-linux-x64.tar.gz to /home/runner/.gradle/.tmp/gradle_download17474928656263925823bin

What's interesting is that it is downloading from a URL that includes .../release-candidates/... instead of downloading the snapshot which would have the latest commit for 3.0.0. The bwc test should use the latest commit on main for core when starting up an OS node.
@cwperks cwperks added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 17, 2023
peternied added a commit to peternied/OpenSearch-1 that referenced this issue Jul 17, 2023
@peternied
Priorize snapshot builds in distribution downloader
d0d3f33 
In the Security plugin's BWC tests there have been an issue with stale
artifacts, when troubleshooting we noticed that a release candidate for
OpenSearch 3.0.0 was being picked up in priority before the latest
snapshot build.  This was causing build failures preventing our tests
from running.

- Related opensearch-project/security#3020

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied mentioned this issue Jul 17, 2023
Closed
6 tasks
@peternied peternied added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 17, 2023
@peternied
Copy link
Member

[Triage] Thanks for filing.

@cwperks cwperks mentioned this issue Jul 18, 2023
Merged
3 tasks
@cwperks
Copy link
Member Author

cwperks commented Jul 18, 2023

This has been addressed by #3024

@cwperks cwperks closed this as completed Jul 18, 2023
@cwperks cwperks self-assigned this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwperks cwperks

Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peternied @cwperks