Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.11] Add permissions for async query and patch datasource API #1631

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c784665 from #1626

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit c784665)
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1631 (a6f6d98) into 2.11 (bcfb488) will increase coverage by 1.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             2.11    #1631      +/-   ##
==========================================
+ Coverage   66.18%   67.93%   +1.75%     
==========================================
  Files          93       93              
  Lines        2339     2339              
  Branches      317      317              
==========================================
+ Hits         1548     1589      +41     
  Misses        722      722              
+ Partials       69       28      -41     
Files Coverage Δ
public/apps/configuration/constants.tsx 86.20% <ø> (ø)

... and 17 files with indirect coverage changes

@cwperks cwperks merged commit ffc793f into 2.11 Oct 24, 2023
16 checks passed
@github-actions github-actions bot deleted the backport/backport-1626-to-2.11 branch October 24, 2023 02:35
@peternied
Copy link
Member

@DarshitChanpura @cwperks @cliu123 @cwperks @davidlago @scrawfor99
This change shouldn't have been backported to 2.11, only to 2.x. Please keep this in mind when reviewing future changes.

@cwperks
Copy link
Member

cwperks commented Nov 2, 2023

@peternied should this be reverted?

@peternied
Copy link
Member

Good question, I've thought about it however, this is a harmless change to keep for a 2.11.1 release and I'd rather not create churn unnecessarily. If we get guidance about this we can pivot at that time.

cwperks added a commit to cwperks/security-dashboards-plugin that referenced this pull request Nov 6, 2023
cwperks added a commit that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants