-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.8] Fixing dynamic tenancy changes for issues 1412 #1457
[Backport 2.8] Fixing dynamic tenancy changes for issues 1412 #1457
Conversation
* Fixing dynamic tenancy changes for opensearchdasbhoard.yaml Signed-off-by: Abhi Kalra <abhivka@amazon.com> Co-authored-by: Abhi Kalra <abhivka@amazon.com> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> (cherry picked from commit c4e6c37)
FYI: The prerequisite check will not block the merging. |
Codecov Report
@@ Coverage Diff @@
## 2.8 #1457 +/- ##
==========================================
- Coverage 65.51% 65.47% -0.05%
==========================================
Files 93 93
Lines 2294 2297 +3
Branches 307 313 +6
==========================================
+ Hits 1503 1504 +1
- Misses 723 725 +2
Partials 68 68
|
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@DarshitChanpura @RyanL1997 I had to push a change to update the versions referenced in the new workflow. Since the workflow is testing the code introduced in this PR we should verify those checks before merging. |
Per @cwperks and @RyanL1997 this is a flaky test (12th run pass on this specific PR), which will be addressed in the next minor version. Merge now. Thanks. |
Thanks @peterzhuamazon for the help on merging. Yes, this is a known flaky, and this fix has already planned to remove it for 2.8 branch |
Great thanks. |
Backport of #1419 to 2.8