Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query_field_names bugfix #335

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Feb 18, 2023

Description

Fixed query_field_names being accumulated when loading per-packgaged rules

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz petardz requested a review from a team February 18, 2023 00:22
…es; fixed rule index mappings; fixed error message in GetIndexMappings API

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Merging #335 (1313efd) into main (78ea8be) will decrease coverage by 0.11%.
The diff coverage is 11.11%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #335      +/-   ##
============================================
- Coverage     36.96%   36.86%   -0.11%     
+ Complexity      887      886       -1     
============================================
  Files           179      179              
  Lines          7010     7032      +22     
  Branches        855      857       +2     
============================================
+ Hits           2591     2592       +1     
- Misses         4182     4202      +20     
- Partials        237      238       +1     
Impacted Files Coverage Δ
...securityanalytics/mapper/IndexTemplateManager.java 0.00% <0.00%> (ø)
...search/securityanalytics/mapper/MapperService.java 4.61% <0.00%> (+0.06%) ⬆️
...ch/securityanalytics/mapper/MappingsTraverser.java 82.35% <ø> (ø)
.../securityanalytics/rules/backend/QueryBackend.java 64.34% <0.00%> (-1.14%) ⬇️
...opensearch/securityanalytics/util/RuleIndices.java 0.00% <0.00%> (ø)
...rityanalytics/util/SecurityAnalyticsException.java 36.66% <33.33%> (ø)
...rch/securityanalytics/rules/objects/SigmaRule.java 91.20% <100.00%> (+0.19%) ⬆️
...g/opensearch/securityanalytics/model/Detector.java 70.24% <0.00%> (-0.35%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbcd90 sbcd90 merged commit b3ea840 into opensearch-project:main Feb 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit b3ea840)
petardz added a commit to petardz/security-analytics that referenced this pull request Feb 21, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
sbcd90 pushed a commit that referenced this pull request Feb 21, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
petardz added a commit to petardz/security-analytics that referenced this pull request Feb 22, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Apr 3, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
engechas pushed a commit to engechas/security-analytics that referenced this pull request Mar 14, 2024
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@engechas engechas mentioned this pull request Mar 15, 2024
5 tasks
engechas added a commit that referenced this pull request Mar 15, 2024
* query_field_names bugfix (#335)

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* Reduce log level for informative message (#203)

Signed-off-by: Enrico Tröger <enrico.troeger@uvena.de>

* fix detector writeTo() method missing fields (#695)

* fix detector writeTo() method missing fields

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix test

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix null query filter conversion from sigma to query string query (#722)

* fix null query filter conversion from sigma to query string query

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix rule to query conversion tests for null filter

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* enhance test to verify non null doc doesnt match null query

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* Bump version 2.5.1, fix build

Signed-off-by: Chase Engelbrecht <engechas@amazon.com>

* Manual cherry-pick of #873

Signed-off-by: Chase Engelbrecht <engechas@amazon.com>

* Fix miss from manual cherry-pick

Signed-off-by: Chase Engelbrecht <engechas@amazon.com>

* Undo exceptional case not originally present

Signed-off-by: Chase Engelbrecht <engechas@amazon.com>

* Revert test from previous commit reversion

Signed-off-by: Chase Engelbrecht <engechas@amazon.com>

* Fix another miss from manual cherry-pick

Signed-off-by: Chase Engelbrecht <engechas@amazon.com>

* Revert behavior for no rules in detector

Signed-off-by: Chase Engelbrecht <engechas@amazon.com>

---------

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Enrico Tröger <enrico.troeger@uvena.de>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Chase Engelbrecht <engechas@amazon.com>
Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com>
Co-authored-by: Enrico Tröger <enrico.troeger@uvena.de>
Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Mar 25, 2024
* Added support for JDK 8 and 14.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Added support for JDK 8 and 14.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants