-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Add exists check for IOCs index. #1392
Merged
AWSHurneyt
merged 2 commits into
opensearch-project:main
from
AWSHurneyt:3.0-threat-intel-batch-size-bug
Oct 25, 2024
Merged
[Bug] Add exists check for IOCs index. #1392
AWSHurneyt
merged 2 commits into
opensearch-project:main
from
AWSHurneyt:3.0-threat-intel-batch-size-bug
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g more than 10k iocs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
requested review from
amsiglan,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
October 25, 2024 04:52
Adding tests locally currently. Manually testing no longer results in the |
eirsep
reviewed
Oct 25, 2024
src/main/java/org/opensearch/securityanalytics/services/STIX2IOCFeedStore.java
Outdated
Show resolved
Hide resolved
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
eirsep
approved these changes
Oct 25, 2024
AWSHurneyt
changed the title
[Bug] Indexing more than 10k IOCs.
[Bug] Add exists check for IOCs index.
Oct 25, 2024
jowg-amazon
approved these changes
Oct 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Added check to prevent resource_already_exists_exception when indexing more than 10k iocs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Changed log message. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 4432b36) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Added check to prevent resource_already_exists_exception when indexing more than 10k iocs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Changed log message. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 4432b36) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Added check to prevent resource_already_exists_exception when indexing more than 10k iocs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Changed log message. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 4432b36) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Added check to prevent resource_already_exists_exception when indexing more than 10k iocs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Changed log message. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 4432b36) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Added check to prevent resource_already_exists_exception when indexing more than 10k iocs. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Changed log message. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 4432b36) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Added check to prevent resource_already_exists_exception when indexing more than 10k iocs. * Changed log message. --------- (cherry picked from commit 4432b36) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Added check to prevent resource_already_exists_exception when indexing more than 10k iocs. * Changed log message. --------- (cherry picked from commit 4432b36) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Added check to prevent resource_already_exists_exception when indexing more than 10k iocs. * Changed log message. --------- (cherry picked from commit 4432b36) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Added check to prevent resource_already_exists_exception when indexing more than 10k iocs. * Changed log message. --------- (cherry picked from commit 4432b36) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added check to prevent resource_already_exists_exception when indexing more than 10k iocs.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.