Show aliases in data source options for detector and correlation rule creation #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan
requested review from
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90 and
eirsep
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #864 +/- ##
==========================================
- Coverage 31.03% 31.00% -0.03%
==========================================
Files 151 157 +6
Lines 5111 5222 +111
Branches 948 922 -26
==========================================
+ Hits 1586 1619 +33
- Misses 3335 3416 +81
+ Partials 190 187 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
|
The only failing cypress tests are in |
AWSHurneyt
approved these changes
Feb 7, 2024
This was referenced Feb 7, 2024
eirsep
approved these changes
Feb 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
… creation (#864) * show aliases under data source dropdowns Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * add manage rules entrypoint in creation UI Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * fixed integ test Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 95560a8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Feb 7, 2024
… creation (#864) (#870) * show aliases under data source dropdowns * add manage rules entrypoint in creation UI * fixed integ test --------- (cherry picked from commit 95560a8) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we only show indices inside the data source options for create/update Detector and Correlation rule. This PR adds aliases to that list and categorizes the two for more options.
This PR also adds an external link to the Rules page to provide an entry point to rules management in case Users don't see the rule they want to setup in the detector
Issues Resolved
#863
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.