[Backport 2.x] Updating Preview Message functionality while setting notifications in detector alerts #1241 #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… detector alerts (opensearch-project#1241) * Updated Preview Message experience for notifications in detector trigger setup * Updated detector notification template * updated code review comments * Updated context type being passed to detector notification form (cherry picked from commit a72fbc0) Signed-off-by: Nishtha Mehrotra <nishtham.nishtham@amazon.com>
nishtham-amazon
force-pushed
the
backport-1241-to-2.x
branch
from
3cad02e to
ac00d1e
Compare
sbcd90
approved these changes
Jan 29, 2025
eirsep
approved these changes
Jan 29, 2025
riysaxen-amzn
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the message preview feature while setting notifications for detector triggers. The user can click on Preview message check box and view the notification content. The user can also update the message subject and body which will be updated in the notification content.
Current behaviour
Updated Preview
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.