fix: fix a bug that loading spinner is on when there is no data

Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com>
opensearch-project · Jan 30, 2025 · ce1bbd9 · ce1bbd9
1 parent 22f4ecc
commit ce1bbd9
Showing 1 changed file with 20 additions and 2 deletions.
diff --git a/public/pages/Correlations/containers/CorrelationsContainer.tsx b/public/pages/Correlations/containers/CorrelationsContainer.tsx
@@ -807,7 +807,7 @@ export class Correlations extends React.Component<CorrelationsProps, Correlation
   };
 
   private renderCorrelationsTable = (loadingData: boolean) => {
-    if (loadingData) {
+    if (this.state.correlationsTableData.length && loadingData) {
       return (
         <div style={{ margin: '0px 47%', height: 800, paddingTop: 384 }}>
           <EuiLoadingChart size="xl" className="chart-view-container-loading" />
@@ -817,11 +817,29 @@ export class Correlations extends React.Component<CorrelationsProps, Correlation
 
     const filteredTableData = this.getFilteredTableData(this.state.correlationsTableData);
 
-    return (
+    return filteredTableData.length > 0 ? (
       <>
         {this.renderCorrelatedFindingsChart()}
         <CorrelationsTable tableData={filteredTableData} onViewDetails={this.openTableFlyout} />
       </>
+    ) : (
+      <EuiEmptyPrompt
+        title={
+          <EuiText size="s">
+            <h2>No correlations found</h2>
+          </EuiText>
+        }
+        body={
+          <EuiText size="s">
+            <p>There are no correlated findings in the system.</p>
+          </EuiText>
+        }
+        actions={[
+          <EuiSmallButton fill={true} color="primary" href={`#${ROUTES.CORRELATION_RULE_CREATE}`}>
+            Create correlation rule
+          </EuiSmallButton>,
+        ]}
+      />
     );
   };