edit correlation Alert Trigger fix (#1180) (#1184)

* edit correlation Alert Trigger fix * delete correlation alert trigger fix * delete correlation alert trigger fix * edit correlation rule trigger fix * edit correlation rule trigger fix * edit correlation rule trigger fix * extra spacing removed --------- (cherry picked from commit 8220c38) Signed-off-by: Riya Saxena <riysaxen@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project · Oct 10, 2024 · bdffca4 · bdffca4
1 parent 7d22d22
commit bdffca4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/public/pages/Correlations/containers/CreateCorrelationRule.tsx b/public/pages/Correlations/containers/CreateCorrelationRule.tsx
@@ -244,7 +244,6 @@ export const CreateCorrelationRule: React.FC<CreateCorrelationRuleProps> = (
           setInitialValues(ruleRes);
         }
       };
-
       setAction('Edit');
       setInitialRuleValues();
     }
@@ -1079,7 +1078,11 @@ export const CreateCorrelationRule: React.FC<CreateCorrelationRuleProps> = (
                             data-test-subj="delete-alert-trigger-icon"
                             iconType="trash"
                             color="danger"
-                            onClick={() => setShowForm(false)}
+                            onClick={() => {
+                              // Clear the trigger values by setting them to an empty object or your initial state
+                              props.setFieldValue('trigger', {});
+                              setShowForm(false);
+                            }}
                           />
                         </EuiCompressedFormRow>
                       </EuiFlexItem>

diff --git a/public/store/CorrelationsStore.ts b/public/store/CorrelationsStore.ts
@@ -150,6 +150,7 @@ export class CorrelationsStore implements ICorrelationsStore {
         name: hit._source.name,
         time_window: hit._source.time_window || 300000,
         queries,
+        trigger: hit._source?.trigger
       };
     }
 
@@ -175,6 +176,7 @@ export class CorrelationsStore implements ICorrelationsStore {
           name: hit._source.name,
           time_window: hit._source.time_window || 300000,
           queries,
+          trigger: hit._source?.trigger
         };
       });
     }

diff --git a/types/Correlations.ts b/types/Correlations.ts
@@ -54,7 +54,7 @@ export interface CorrelationRuleModel {
   name: string;
   time_window: number; // Time in milliseconds
   queries: CorrelationRuleQuery[];
-  trigger: CorrelationRuleTrigger | undefined;
+  trigger?: CorrelationRuleTrigger;
 }
 
 export interface CorrelationRule extends CorrelationRuleModel {
@@ -76,7 +76,7 @@ export interface CorrelationRuleSource {
   name: string;
   time_window: number;
   correlate: CorrelationRuleSourceQueries[];
-  trigger?: CorrelationRuleTrigger | undefined;
+  trigger?: CorrelationRuleTrigger;
 }
 
 export interface CorrelationRuleHit {